Zeek JA4L: admit SYN packets that have additional flags #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Zeek script produces incomplete JA4L fingerprints for certain connections.
For example, here is the output produced for macos_tcp_flags.pcap in the "pcap" directory:
For this pcap, the problem seems to occur because the script does not recognize SYN packets that contain additional TCP flags.
This pull request modifies the script to recognize any packet that has its SYN flag set and its ACK flag clear.
This issue was previously fixed in the Python #23 and Rust #24 implementations. (Issue 22)