Skip to content

fix(props): ensure fluidOnMobile passes through #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
Merged

fix(props): ensure fluidOnMobile passes through #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils/mjml-component-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export function convertPropsToMjmlAttributes<P>(props: {
return mjmlProps;
}

const booleanToString = ["inline", "full-width"];
const booleanToString = ["inline", "full-width", "fluid-on-mobile"];
const numberToPixel = [
"width",
"height",
Expand Down
5 changes: 4 additions & 1 deletion test/mjml-props.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,16 @@ describe("mjml components prop values", () => {
).toBe(`<mj-raw i-am-not-a-prop="random"></mj-raw>`);
});

it("fullWidth and inline props convert to string", () => {
it("fullWidth, inline, and fluidOnMobile props convert to string", () => {
expect(renderToMjml(<mjmlComponents.MjmlSection fullWidth />)).toBe(
`<mj-section full-width="full-width"></mj-section>`
);
expect(renderToMjml(<mjmlComponents.MjmlStyle inline />)).toBe(
`<mj-style inline="inline"></mj-style>`
);
expect(renderToMjml(<mjmlComponents.MjmlImage fluidOnMobile />)).toBe(
`<mj-image fluid-on-mobile="fluid-on-mobile"></mj-image>`
);
});

it("enum prop type accepts all enum values", () => {
Expand Down