Specify GitHub in the manifest #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I initially had gone this route (restricting to just the GitHub.com domain), but realized it would be limiting anyone that wanted to use this for GH Enterprise. I'll look a bit more into dynamic permissions for Chrome extensions, to see if I can just add an option for users to add their own hostname. I definitely don't like having to request access to all pages, but last time I checked, dynamic host permissions were pretty limited. P.S. Thanks for contributing! |
|
@DrewML |
|
Perfect! Thanks for the heads-up. |
edfd558 to
84ac5ae
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change the behavior of the extension, but makes sure that the extension only gets loaded into GitHub pages. You could probably
messageIfFound()function in the inject.js file since this ensures it's only a Github page, but I didn't go that far.