Skip to content

[PROF-9088] Use Go build id as fallback for gnu build id #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2024
Merged

[PROF-9088] Use Go build id as fallback for gnu build id #384

merged 1 commit into from
Mar 6, 2024

Conversation

nsavoire
Copy link
Collaborator

@nsavoire nsavoire commented Mar 6, 2024

What does this PR do?

If the gnu build id is not available, use the Go build id if present.

@nsavoire nsavoire force-pushed the nsavoire/go_build_id branch 2 times, most recently from 598793a to 1d087e1 Compare March 6, 2024 10:02
@pr-commenter
Copy link

pr-commenter bot commented Mar 6, 2024 •
edited
Loading

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.17.0+7730467d.28708772 ddprof 0.17.0+0b907d6c.29603659

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter
Copy link

pr-commenter bot commented Mar 6, 2024 •
edited
Loading

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.17.0+7730467d.28708772 ddprof 0.17.0+0b907d6c.29603659

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

r1viollet
r1viollet previously approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nsavoire nsavoire force-pushed the nsavoire/go_build_id branch from 1d087e1 to 4f09010 Compare March 6, 2024 12:32
@nsavoire
Use Go build id as fallback for gnu build id
0b907d6 
If the gnu build id is not available, use the Go build id if present.
@nsavoire nsavoire force-pushed the nsavoire/go_build_id branch from 4f09010 to 0b907d6 Compare March 6, 2024 12:39
@nsavoire nsavoire requested a review from r1viollet March 6, 2024 12:57
r1viollet
r1viollet approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nsavoire nsavoire merged commit c4bf26f into main Mar 6, 2024
@nsavoire nsavoire deleted the nsavoire/go_build_id branch March 6, 2024 14:51
@r1viollet r1viollet changed the title Use Go build id as fallback for gnu build id [PROF-9088] Use Go build id as fallback for gnu build id Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r1viollet r1viollet r1viollet approved these changes

@sanchda sanchda Awaiting requested review from sanchda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsavoire @r1viollet