Skip to content

Conversation

marco-saia-datadog
Copy link
Member

What does this PR do?

Fixes an iOS new architecture build error that occurs when setting USE_FRAMEWORKS:

In file included from /app/node_modules/@datadog/mobile-react-native-session-replay/ios/Sources/RCTFabricWrapper.mm:13:
/app/node_modules/react-native/ReactCommon/react/renderer/components/text/ParagraphProps.h:14:10: fatal error: 'react/renderer/components/text/BaseTextProps.h' file not found
   14 | #include <react/renderer/components/text/BaseTextProps.h>

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 16, 2025

Datadog Report

Branch report: marcosaia/fix/sr-use-frameworks-newarch-error
Commit report: bc27588
Test service: dd-sdk-reactnative

✅ 0 Failed, 663 Passed, 1 Skipped, 4.97s Total Time

@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/fix/sr-use-frameworks-newarch-error branch from f5da553 to bc27588 Compare June 17, 2025 12:16
@marco-saia-datadog marco-saia-datadog marked this pull request as ready for review June 19, 2025 12:44
@marco-saia-datadog marco-saia-datadog requested a review from a team as a code owner June 19, 2025 12:44
@marco-saia-datadog marco-saia-datadog merged commit f81a30a into develop Jun 19, 2025
10 checks passed
@marco-saia-datadog marco-saia-datadog deleted the marcosaia/fix/sr-use-frameworks-newarch-error branch June 19, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants