Improvements to the JMX Checks #337
Conversation
remh
commented
Jan 11, 2013
- When the connection fails 3 times in a row, we won't try to open it up again.
- The jmx process can be launched with a different priority (not by default)
- I added an option in the jmx terminal to do a prefiltering of the values that are fetched which seems to add more stability to the jmx connector
- Better failure handling
- The check will only dump jmx domains that are actually used
checks/jmx_connector.py
Outdated
There was a problem hiding this comment.
if priority == DEFAULT_PRIORITY:
There was a problem hiding this comment.
No, if the default_priority is set to another value we will have to use the nice command.
The only case where we won't use nice is when the priority==0
There was a problem hiding this comment.
Ok, I'll make it a bit more explicit.
|
Why create a closure here? dd-agent/checks/jmx_connector.py Line 472 in 865d85a If the function ends up being passed around, won't |
|
It's a workaround for solr as solr domain name is not completely known, so for solr we fetch everything and then we filter. |