Skip to content

Check haproxy #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

Check haproxy #113

wants to merge 14 commits into from

Conversation

remh
Copy link

@remh remh commented Jul 19, 2012

First version of the haproxy check

@ghost ghost assigned alq666 Jul 19, 2012
@alq666
Copy link
Contributor

alq666 commented Jul 19, 2012

test_haproxy.py needs a bit of love? once it actually does something travis should run it and pass.

If you need help with travis, let me know (.travis.yml). We can basically apt-get haproxy to have a running instance on localhost.

@remh
Copy link
Author

remh commented Jul 19, 2012

Thanks I didn't know about travis.
I'm having a look and will write some tests.

@clofresh
Copy link
Contributor

Why does this branch modify the elasticsearch check?

@remh
Copy link
Author

remh commented Jul 19, 2012

@clofresh that's weird I haven't changed anything in the elasticsearch check. Maybe a bug while merging.

clofresh
clofresh reviewed Jul 19, 2012
View reviewed changes
checks/net/haproxy.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datetime.now() will return the local time, which will give you the wrong unix timestamp. You actually want to do datetime.utcnow()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, you should be using the time that the haproxy log said that that event happened, because it isn't necessarily the same as now.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@alq666 alq666 closed this in 180ad9c Jul 30, 2012
alq666 pushed a commit that referenced this pull request Jul 30, 2012
@ddalq
Extended tests for haproxy #113
6720a5a 
@remh
@alq666 alq666 reopened this Aug 23, 2012
@alq666
Copy link
Contributor

alq666 commented Aug 23, 2012

Verified on 3.1.0.

@alq666 alq666 closed this Aug 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alq666 alq666

Labels

None yet

Projects

None yet

Milestone

3.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@remh @alq666 @clofresh @ddalq