fix(runtimes): Allow datadog-api-client to work in Vercel's Edge Runtime #934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, datadog-api-client was not compatible with Vercel's Edge Runtime (https://edge-runtime.vercel.app/). 1. While `process` exists, process.release doesn't. So changes from DataDog#899 were not complete 2. I added a few more code to really identify Edge Runtime as a different Node.js (server) environment that can use fetch Let me know if that's OK.
|
Thanks for your patch. I think we'll try to reduce the number of isNode call instead, and check for |
|
@therve do you need me to update that PR? For now, we've used https://pnpm.io/cli/patch to allow us to make progress (and it's working). But ideally this would be done inside this repository 👍 |
|
We tried something in #938 , let us know if that works for you. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before this commit, datadog-api-client was not compatible with Vercel's Edge Runtime (https://edge-runtime.vercel.app/).
processexists, process.release doesn't. So changes from Remove node specific checks and unblock running in workers #899 were not completeLet me know if that's OK.
Additional Notes
n/a
Review checklist
Please check relevant items below:
n/a [ ] This PR includes all newly recorded cassettes for any modified tests