-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Upgrade viem from 2.13.1 to 2.38.3 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade viem from 2.13.1 to 2.38.3. See this package in yarn: viem See this project in Snyk: https://app.snyk.io/org/apichanmittare/project/2749ecc3-509c-4550-ba7a-f6f899e9eb4c?utm_source=github&utm_medium=referral&page=upgrade-pr
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a critical dependency upgrade for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, upgrades the viem package from version 2.13.1 to 2.38.3. This is a significant update, spanning 252 versions. While Snyk has marked this as a non-breaking change, the large version jump warrants careful testing to ensure no regressions are introduced. The yarn.lock file has been updated accordingly, reflecting changes in transitive dependencies. A notable point is that this project will now have two different versions of viem in its dependency tree, which could increase bundle size. It might be beneficial to investigate if @safe-global/safe-apps-sdk can be updated to use a newer version of viem to deduplicate this dependency.
| "rehype-raw": "^7.0.0", | ||
| "sharp": "^0.32.6", | ||
| "viem": "^2.13.1", | ||
| "viem": "^2.38.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very large version jump for viem (from 2.13.1 to 2.38.3). Although it's not a major version change and Snyk reports no breaking changes, it's critical to perform thorough regression testing to ensure the application continues to function as expected. Given the extensive changes across 252 versions, there's a high risk of subtle bugs or performance regressions.
Snyk has created this PR to upgrade viem from 2.13.1 to 2.38.3.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 252 versions ahead of your current version.
The recommended version was released a month ago.
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: