-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Upgrade wagmi from 2.12.12 to 2.18.2 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade wagmi from 2.12.12 to 2.18.2. See this package in yarn: wagmi See this project in Snyk: https://app.snyk.io/org/apichanmittare/project/2749ecc3-509c-4550-ba7a-f6f899e9eb4c?utm_source=github&utm_medium=referral&page=upgrade-pr
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the project's security posture by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, upgrades the wagmi dependency from 2.12.12 to 2.18.2 to address several critical and high-severity security vulnerabilities. While this is an important and necessary update, the review has identified a critical issue: the viem dependency, a peer of wagmi, has not been upgraded alongside it. This can lead to multiple versions of viem in the project, causing potential runtime errors and incorrect behavior. It is strongly recommended to upgrade viem to a compatible version to ensure the stability and correctness of the application.
| "sharp": "^0.32.6", | ||
| "viem": "^2.13.1", | ||
| "wagmi": "^2.12.12", | ||
| "wagmi": "^2.18.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While upgrading wagmi is crucial for security, it's equally important to upgrade its peer dependency viem to avoid runtime issues. wagmi and viem are tightly coupled, and a version mismatch can lead to subtle bugs and errors like instanceof checks failing.
Your package.json currently specifies viem: "^2.13.1", which is outdated for this version of wagmi. Other dependencies are already pulling in much newer versions of viem (up to 2.39.0 as seen in yarn.lock), creating multiple viem versions in your node_modules.
To ensure compatibility and a single version of viem, please upgrade it in your package.json alongside wagmi. I recommend aligning it with the latest versions being used. You should modify line 28 in package.json to:
"viem": "^2.39.0"
Snyk has created this PR to upgrade wagmi from 2.12.12 to 2.18.2.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 69 versions ahead of your current version.
The recommended version was released 22 days ago.
Issues fixed by the recommended upgrade:
SNYK-JS-COINBASEWALLETSDK-8717118
SNYK-JS-ELLIPTIC-7577916
SNYK-JS-ELLIPTIC-7577917
SNYK-JS-ELLIPTIC-7577918
SNYK-JS-ELLIPTIC-8172694
SNYK-JS-ELLIPTIC-8187303
SNYK-JS-ELLIPTIC-8720086
SNYK-JS-ELLIPTIC-8187303
SNYK-JS-ELLIPTIC-8720086
SNYK-JS-SECP256K1-8237220
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: