Skip to content

Conversation

@ggbecker
Copy link
Member

@ggbecker ggbecker commented Oct 25, 2021

Description:

  • Integrate compare_ds.py tool to Github Actions

Rationale:

The workflow will only trigger after it's already merged. So the test commit should be purged because it has no effect right now.

@ggbecker
Copy link
Member Author

Preview: ggbecker#14 (comment)

@ggbecker ggbecker requested review from evgenyz and jan-cerny November 1, 2021 14:47
@evgenyz
Copy link
Member

evgenyz commented Nov 8, 2021

How about using https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#workflow_run with single if: ${{ steps.ctf.outputs.CTF_OUTPUT_SIZE != '0' }} for the real diff job?

We could be able to use single https://github.com/ComplianceAsCode/content/blob/master/.github/workflows/ctf.yaml workflow as a dependency for all other jobs that require its output.

@ggbecker
Copy link
Member Author

ggbecker commented Nov 9, 2021

How about using https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#workflow_run with single if: ${{ steps.ctf.outputs.CTF_OUTPUT_SIZE != '0' }} for the real diff job?

We could be able to use single https://github.com/ComplianceAsCode/content/blob/master/.github/workflows/ctf.yaml workflow as a dependency for all other jobs that require its output.

we can definitely improve how jobs relate to each other and put them as dependency of each other. I will take a look at this.

@ggbecker
Copy link
Member Author

ggbecker commented Nov 9, 2021

How about using https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#workflow_run with single if: ${{ steps.ctf.outputs.CTF_OUTPUT_SIZE != '0' }} for the real diff job?
We could be able to use single https://github.com/ComplianceAsCode/content/blob/master/.github/workflows/ctf.yaml workflow as a dependency for all other jobs that require its output.

we can definitely improve how jobs relate to each other and put them as dependency of each other. I will take a look at this.

I'm starting to think that this is not a good idea. There are some limitations, for example the job that runs on a workflow_run doesn't know the PR context and after some tries I was not even able to make it work properly (ggbecker#18)

Maybe we can use the same workflow file to accommodate all of these jobs that depend on CTF and use the simple needs keyword.

I have to investigate more. But I think we shouldn't block this one to get merged as we can refactor and improve the jobs later.

@evgenyz
Copy link
Member

evgenyz commented Nov 9, 2021

Yeah, you're probably right. I just don't like CTF sprawling and wedging all over the place unchecked.

@evgenyz evgenyz merged commit 475c06a into ComplianceAsCode:master Nov 9, 2021
@yuumasato yuumasato added this to the 0.1.59 milestone Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants