-
Notifications
You must be signed in to change notification settings - Fork 5
docs: demonstrate LS-coupling in notebook #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
|
@sebastianJaeger could you have a look at the text here? Perhaps easiest to review the notebook in ReviewNB: |
This is listed in the particle package
|
There were still some mistakes in the example calculation. They are fixed in 1fd6e5c. |
|
1fd6e5c also introduces some code to demonstrate that QRules returns the same LS-combinations. It would be better to illustrate each step in the derivation with functions from the |
|
Another problem: 1fd6e5c requires |
redeboer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good now imo 👍
@Leongrim @sebastianJaeger, if you have more comments, you can leave them here:
https://app.reviewnb.com/ComPWA/qrules/blob/ls-coupling/docs/usage/ls-coupling.ipynb
Preview of the notebook with cell output can be viewed here:
https://qrules--124.org.readthedocs.build/en/124/usage/ls-coupling.html
Closes #109