Skip to content

Conversation

@Leongrim
Copy link
Contributor

Closes #109

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@redeboer redeboer changed the title Ls coupling docs: demonstrate LS-coupling in notebook Nov 17, 2021
@redeboer redeboer added the 📝 Docs Improvements or additions to documentation label Nov 17, 2021
@redeboer redeboer assigned redeboer and Leongrim and unassigned redeboer Nov 17, 2021
@redeboer redeboer self-requested a review November 17, 2021 15:45
@redeboer redeboer added this to the 0.9.5 milestone Nov 17, 2021
@redeboer redeboer marked this pull request as ready for review November 17, 2021 16:48
@redeboer redeboer marked this pull request as draft November 18, 2021 10:58
@redeboer redeboer self-assigned this Nov 18, 2021
@redeboer
Copy link
Member

@sebastianJaeger could you have a look at the text here? Perhaps easiest to review the notebook in ReviewNB:
https://app.reviewnb.com/ComPWA/qrules/blob/ls-coupling/docs/usage/ls-coupling.ipynb

This is listed in the particle package
@redeboer
Copy link
Member

There were still some mistakes in the example calculation. They are fixed in 1fd6e5c.

@redeboer
Copy link
Member

1fd6e5c also introduces some code to demonstrate that QRules returns the same LS-combinations. It would be better to illustrate each step in the derivation with functions from the conservation_rules module, but the current interface does not really allow for any illustrative code samples. The solution would be to expose some of the domain generation functions used by the StateTransitionManager (not sure if this is even possible) and use those to find all allowes LS-combinations.

@redeboer
Copy link
Member

Another problem: 1fd6e5c requires strip_spin and render_node, which is currently not allowed. This will be fixed in another PR.

@redeboer redeboer marked this pull request as ready for review November 18, 2021 16:21
Copy link
Member

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good now imo 👍
@Leongrim @sebastianJaeger, if you have more comments, you can leave them here:
https://app.reviewnb.com/ComPWA/qrules/blob/ls-coupling/docs/usage/ls-coupling.ipynb

Preview of the notebook with cell output can be viewed here:
https://qrules--124.org.readthedocs.build/en/124/usage/ls-coupling.html

@Leongrim Leongrim merged commit 095f0b9 into main Nov 19, 2021
@Leongrim Leongrim deleted the ls-coupling branch November 19, 2021 08:44
@redeboer redeboer modified the milestones: 0.9.6, 0.9.5 Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📝 Docs Improvements or additions to documentation

Projects

Status: Released

Development

Successfully merging this pull request may close these issues.

Write parity conservation example notebook

5 participants