Skip to content

Conversation

@redeboer
Copy link
Member

Turn StateTransitionCollection into an immutable abc.Sequence, instead of a set.

@redeboer redeboer added the ⚠️ Interface Breaking changes to the API label Jun 22, 2021
@redeboer redeboer added this to the 0.9.1 milestone Jun 22, 2021
@redeboer redeboer self-assigned this Jun 22, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@redeboer redeboer enabled auto-merge (squash) June 22, 2021 20:48
@redeboer redeboer force-pushed the sorted-StateTransitionCollection branch from 14f2f19 to d52187b Compare June 23, 2021 09:18
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #77 (d52187b) into main (a2acefb) will decrease coverage by 0.16%.
The diff coverage is 73.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   93.54%   93.38%   -0.17%     
==========================================
  Files          14       14              
  Lines        3084     3097      +13     
==========================================
+ Hits         2885     2892       +7     
- Misses        199      205       +6     
Flag Coverage Δ
unittests 93.38% <73.68%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qrules/transition.py 87.94% <73.68%> (-1.02%) ⬇️

@redeboer redeboer merged commit 8230306 into main Jun 23, 2021
@redeboer redeboer deleted the sorted-StateTransitionCollection branch June 23, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚠️ Interface Breaking changes to the API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants