Skip to content

Conversation

@redeboer
Copy link
Member

Rename particles argument in several functions to particle_db. This naming was introduced for check_reaction_violations (#40) and makes more sense to the reader.

This naming was introduced for check_reaction_violations (#40) and
makes more sense to the reader
@redeboer redeboer added the ⚠️ Interface Breaking changes to the API label Apr 16, 2021
@redeboer redeboer added this to the 0.8.0 milestone Apr 16, 2021
@redeboer redeboer self-assigned this Apr 16, 2021
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #50 (2c90866) into main (d38d8ae) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   94.23%   94.23%           
=======================================
  Files          14       14           
  Lines        2843     2843           
=======================================
  Hits         2679     2679           
  Misses        164      164           
Flag Coverage Δ
unittests 94.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qrules/combinatorics.py 94.97% <ø> (ø)
src/qrules/io/_dot.py 86.54% <ø> (ø)
src/qrules/__init__.py 96.87% <100.00%> (ø)
src/qrules/_system_control.py 93.83% <100.00%> (ø)
src/qrules/settings.py 98.87% <100.00%> (ø)
src/qrules/transition.py 86.42% <100.00%> (ø)

@redeboer redeboer merged commit 444336a into main Apr 16, 2021
@redeboer redeboer deleted the particle_db branch April 16, 2021 10:24
@wgradl wgradl self-requested a review April 16, 2021 10:24
redeboer pushed a commit to redeboer/ComPWA-qrules that referenced this pull request Apr 30, 2022
BREAKING CHANGE: python API changes.

* Change DataSet structure (from ComPWA).
* Also fix all form factor related issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚠️ Interface Breaking changes to the API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants