Fullscreen button #5307
Merged
Fullscreen button #5307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny007in
requested changes
Aug 30, 2023
danny007in
requested changes
Aug 30, 2023
danny007in
requested changes
Sep 1, 2023
danny007in
requested changes
Sep 3, 2023
Collaborator
|
on chrome_kEdLi6OTNf.mp4 |
Collaborator
|
Make PR commit readable https://www.youtube.com/watch?v=gXCkYkLQ3To |
Contributor
Author
I added an keydown event listener to the fullscreen.ts class. However, I could not get it to change the icon on the first Esc. It takes two Esc events to change. Can you have a look? |
Collaborator
|
@glewe |
Contributor
Author
Ok. Thanks. |
Collaborator
|
once check it please. i have pushed some updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a full screen button to the top menu as it was available in the BS4 version.
I saw that there is a PR for this already but it seems to be outdated.
(This is my first PR here so hopefully I did it right).
Best regards,
George