Add a scene or page switcher in the lower right corner of the preview page on issue #43 #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nutsjian
requested changes
Jul 6, 2023
| } | ||
|
|
||
| export const FeatureBar: React.FC<IPointerProps> = (props) => { | ||
| console.log(props); |
Collaborator
There was a problem hiding this comment.
Since we will use ESLint to check the code, it's better to remove the console.log here
| }); | ||
| return nodes; | ||
| } | ||
| console.log(scenePageOptions); |
Collaborator
There was a problem hiding this comment.
Since we will use ESLint to check the code, it's better to remove the console.log here
| import { ProjectPageViewsResultData } from "@/apis/types/resp"; | ||
| import SolidViewFactory from "@/views/SolidViewFactory"; | ||
| import { isNil } from "lodash-es"; | ||
| import _, { isNil } from "lodash-es"; |
Collaborator
There was a problem hiding this comment.
It's better to use import { isNil } from "lodash-es", when build the project, it can reduce the bundle size.
Collaborator
There was a problem hiding this comment.
use isNil(xxx) instead of _.isNil(xxx)
Collaborator
Author
|
I have solved the above problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add a scene or page switcher in the lower right corner of the preview page
Related issues/PRs
Related issues: #43
Brief change log
/solidui-web/src/pages/Designer/Preview/index.tsx
/solidui-web/src/pages/Designer/Preview/PreviewPopup.tsx
/solidui-web/src/pages/Designer/Preview/preview.tsx
Checklist