Setting blending state and Raylib #36
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Yes, that's an issue I had also noticed, What would be even better would be to retrieve the internal state of RLGL to restore the exact blend mode that was set before rendering with R3D, but I believe that's currently quite complicated I'll merge your proposal since it does solve the issue, but I'll revisit and document all of this, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's happening is OpenGL's blend mode state can end up out of sync with what Raylib is tracking it to be since sometimes Raylib is called to change it, like in
r3d_pass_deferred_lights, but other places it's not and doing so would break things anyway becauserlSetBlendModecallsrlDrawRenderBatch. You can see the problem when using forward rendering and trying to use Raylib's drawing functions after callingR3D_End.This is just still calling Raylib, and that will work if it thinks the blend mode has changed, but also setting it directly in case it didn't. It's kind of hacky, but I didn't see a clear way to either always use Raylib, or completely bypass it without having to do something like this anyway.
Feel free to close this if I'm missing something obvious.