add in make uninstall for cmake #3825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMakeLists.txt
Outdated
| # ---[ Export configs generation | ||
| caffe_generate_export_configs() | ||
|
|
||
| # uninstall target |
There was a problem hiding this comment.
You could try to conform with their style of # ---[ uninstall target. Also, the entire block should be placed in line 88.
|
Bumping this with the suggested changes. The uninstall target is really important when doing system wide installations. |
|
updated with @SergioRAgostinho suggestions |
|
It's being almost a year... imo this is a really important feature, can someone review it and merge it? |
This was referenced Mar 22, 2017
|
Thanks for CMake build improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After sudo make install, it is quite cumbersome to remove the installed files manually, especially if CMAKE_INSTALL_PREFIX changed to something like /usr/local. This change allows the user to simply type sudo make uninstall to remove all installed files