Skip to content

Conversation

tdomhan
Copy link
Contributor

@tdomhan tdomhan commented Mar 16, 2014

This PR has two important changes to the hdf5 file handling:

  1. Remove all c++ assert statements, as they were inactive anyway
  2. Added support for a 2-4 dimensional array

Because NDEBUG is set in the Makefile all c++ assert statements were inactive. This can also be seen in of the the statements in io.cpp:

     H5T_class_t class_;
      status = H5LTget_dataset_info(
         file_id, dataset_name_, dims, &class_, NULL);
     assert(class_ == H5T_NATIVE_FLOAT);

This assert statement is always false, because class_ can only take either of the following values: H5T_INTEGER, H5T_FLOAT, H5T_TIME, H5T_STRING, H5T_BITFIELD, H5T_OPAQUE, H5T_COMPOUND, H5T_REFERENCE, H5T_ENUM, H5T_VLEN, H5T_ARRAY.

@sergeyk I think you mainly worked on the hdf5 support earlier. Let me know what you think.

@sergeyk sergeyk self-assigned this Mar 16, 2014
@sergeyk
Copy link
Contributor

sergeyk commented Mar 16, 2014

great commit, i'll make some more changes and merge in a couple of hours

sergeyk added a commit that referenced this pull request Mar 17, 2014
support for more than 2 dimensions in hdf5 files
@sergeyk sergeyk merged commit 13d156d into BVLC:dev Mar 17, 2014
@sergeyk
Copy link
Contributor

sergeyk commented Mar 17, 2014

I'll add my additions in #203

@shelhamer shelhamer mentioned this pull request Mar 18, 2014
mitmul pushed a commit to mitmul/caffe that referenced this pull request Sep 30, 2014
support for more than 2 dimensions in hdf5 files
lukeyeager pushed a commit to lukeyeager/caffe that referenced this pull request Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants