Give back to layer what is layer's, and to factory what is factory's #1270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice separation!
Keeping the core factories in layer factory sounds good to me. We can always follow up to further separate everything. |
|
Thanks for checking :) Also updated the wiki reflecting this change: |
Yangqing
added a commit
that referenced
this pull request
Oct 13, 2014
Give back to layer what is layer's, and to factory what is factory's
Closed
RazvanRanca
pushed a commit
to RazvanRanca/caffe
that referenced
this pull request
Nov 4, 2014
Give back to layer what is layer's, and to factory what is factory's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR puts all registration code near where they are defined. This would allow us to hopefully make layers more modular. For example, if we want to disable a layer, simply put an #ifdef around its cpp file (as well as its declaration).
I don't know where to put all those Creator functions, so they are still inside layer_factory.cpp. Ideally we could also create separate cpp files like conv_layer_factory.cpp and so on, but given the fact that they are all core layers, maybe it's an overkill to separate them anyway.