Skip to content

Conversation

netheril96
Copy link
Contributor

In the dev branch, many new options have been added to the utility convert_imageset, which makes the old style parsing tedious and the usage hard to remember. This PR aims to replace positional argument parsing with gflags, now that it becomes a dependency.

@Yangqing
Copy link
Member

Yangqing commented Aug 5, 2014

Cool, thanks for this!

If you would like, you can also consolidate the utility into the new caffe interface (see tools/caffe.cpp), but this is totally up to you :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may no longer be needed after the most recent bugfix.

@netheril96
Copy link
Contributor Author

I seem to have messed up this git branch by rebasing on the latest dev. How should I clean this up?

@shelhamer
Copy link
Member

Try an interactive rebase of your currently troubled branch by git checkout gflags; git rebase --interactive to remove any commits that aren't part of this PR's contribution. Then pull the latest dev by git checkout dev ; git pull upstream where upstream is the BVLC/caffe remote and now rebase your feature branch onto dev with git checkout gflags ; git rebase dev. Finally force push your correct feature branch to your fork by git push -f netheril96 gflags where netheril96 is the remote for your fork.

@netheril96
Copy link
Contributor Author

Has anyone decided to merge or reject this PR?

@shelhamer
Copy link
Member

This is ready for merge once the existing references to convert_imageset.bin are updated to the new args: https://github.com/BVLC/caffe/blob/dev/examples/imagenet/create_imagenet.sh#L38-L50

Thanks for the improvements to the utility!

@netheril96
Copy link
Contributor Author

@shelhamer
I fixed that shell script, but I lack ImageNet data to test whether the new one actually runs.

shelhamer added a commit that referenced this pull request Aug 28, 2014
Use gflags to parse command line arguments for convert_imageset
@shelhamer shelhamer merged commit d682ed8 into BVLC:dev Aug 28, 2014
@shelhamer
Copy link
Member

Thanks for the named args and simplified logic!

@netheril96 netheril96 deleted the gflags branch September 9, 2014 07:59
@netheril96 netheril96 restored the gflags branch September 9, 2014 07:59
@shuokay
Copy link

shuokay commented Sep 17, 2014

#847 still not solved.

~/ocr/gys/subocr] ../caffe/build/tools/convert_imageset -g / train.txt train.lmdb 1 lmdb 12 8
F0917 19:22:19.116093 16547 convert_imageset.cpp:112] Check failed: mdb_env_open(mdb_env, argv[3], 0, 0664) == 0 (20 vs. 0) mdb_env_open failed
*** Check failure stack trace: ***
    @     0x7fb1a5c8eb7d  google::LogMessage::Fail()
    @     0x7fb1a5c90c7f  google::LogMessage::SendToLog()
    @     0x7fb1a5c8e76c  google::LogMessage::Flush()
    @     0x7fb1a5c9151d  google::LogMessageFatal::~LogMessageFatal()
    @           0x413067  main
    @     0x7fb1a2c8f78d  (unknown)
    @           0x413edd  (unknown)
Aborted (core dumped)

leveldb backend is ok, but not lmdb backend. I am using the master branch

@netheril96
Copy link
Contributor Author

@shuokay

Are you posting to the wrong place? This PR has changed the syntax for calling convert_imageset and your example code should throw a different kind of error.

@shuokay
Copy link

shuokay commented Sep 17, 2014

I am going home now and I will review my code tomorrow and update the result here. thx

发自我的 iPhone

在 2014年9月17日,下午7:30,netheril96 [email protected] 写道:

@shuokay

Are you posting to the wrong place? This PR has changed the syntax for calling convert_imageset and your example code should throw a different kind of error.


Reply to this email directly or view it on GitHub.

@shuokay
Copy link

shuokay commented Sep 18, 2014

@netheril96 ,you are right. I had posted to the wrong place. sorry.

mitmul pushed a commit to mitmul/caffe that referenced this pull request Sep 30, 2014
Use gflags to parse command line arguments for convert_imageset
RazvanRanca pushed a commit to RazvanRanca/caffe that referenced this pull request Nov 4, 2014
Use gflags to parse command line arguments for convert_imageset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants