Fix for buffer overflow problem with long filenames when setting up the LevelDB #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shelhamer
added a commit
that referenced
this pull request
Feb 5, 2014
Fix for buffer overflow problem with long filenames when setting up the LevelDB
|
Thanks! A nice, round number like 256 is a better limit haha. |
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
Fix for buffer overflow problem with long filenames when setting up the LevelDB
lukeyeager
added a commit
to lukeyeager/caffe
that referenced
this pull request
Nov 5, 2015
restored 95% of memory grabbed by CNMEM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had filenames that were longer than the 100 character limit, and they caused the buffer overflow checking code in sprintf() to trigger. Switching to snprintf() with an explicit 256 character limit fixed the problem in my case.