Add split dim layer #680
Add split dim layer #680
Conversation
|
@sguada Can you give me a feedback? |
|
@shelhamer Can anybody give me a feedback? |
|
@bhack Although I think having fixed size slice/split can be useful in some specific situations, I think to make it really compatible as Concat reverse one would need to specify different sizes. As mentioned in our previous conversation in #596 I would add another repeated param, slice_point that would allow to define the points for slicing, and therefore obtain different sizes blobs. So either there are no slice_point defined, in which case it will use equal size slices, or if there defined, then there should be one per top. @bhack if your think adding this feature would be too complex, we can leave it for another PR. Agree with @shelhamer in that Slice could be a better name. |
|
Renamed. I've also tried to add split index. |
There was a problem hiding this comment.
Takes one bottom blob, ...
creates as many top blobs as needed
Differentiate top test blob vector size Rename to SplitLayer Add slicing points
There was a problem hiding this comment.
Add another test for set_slice_dim(1)
There was a problem hiding this comment.
Is the next TestCPUSetupChannels. Default dim is 1
|
Please address some of the comments and wait for Travis to pass all the test, after that it could be merged. |
Implement a split by dim layer.
Please take a look at #596 comments