Boosteigencompilewithboost146 #49
Conversation
previously filled in all NaNs for me, making many tests fail)
|
Boosteigencompilewithboost is a very nice word (is it German?) Boosteigenkompilewitboosten! |
make compatible with boost 1.46 and 1.55
|
Bestätigt! Fixes #47 |
|
Indeed, in the initial private branch variate_generator was used following the Boost random_demo. Being unaware of the Boost ticket 904, I did not change rodrigob's implementation in commit 1bcdfd4. As shown in my first comment to #16, I thought "boost::uniform_real is deprecated by uniform_real_distribution" because I installed the most recent version of Boost. But in an open source project especially one that is a uprising popular star like Caffe, compatibility to most of the possible development environments surely should be one of the top priorities for all the user to able to use and contribute to the project without hassles. Thank you all for this lesson! |
Actually, I wasn't quite able to compile using Boost 1.46 with the previous pull request (whoops) -- had to change boost::random::uniform_real_distribution to boost::uniform_real. When I did compile successfully, I had a bunch of tests failing with 1.46 due to vRngGaussian generating all NaNs. I changed all RNGs to use Boost's "variate_generator" (I think this is the Right Way based on https://svn.boost.org/trac/boost/ticket/904) and this was fixed (compiles and passes all tests in both 1.46 and 1.54).