Improve python interface for the solver #4342
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python/caffe/test/test_solver.py
Outdated
| self.assertTrue((data - -0.01 * np.ones(data.shape)).max() < 1e-7) | ||
|
|
||
|
|
||
|
|
|
Seems like a bit of an odd case, but I guess it makes sense; one might also want to change the iter for debugging or other purposes. |
|
@longjon updated as required |
include/caffe/solver.hpp
Outdated
| return test_nets_; | ||
| } | ||
| int iter() { return iter_; } | ||
| void SetIter(int iter) { iter_ = iter; } |
There was a problem hiding this comment.
Ah, I noticed this before but neglected to comment (sorry!): this should be set_iter; trivial functions use underscore_case (like the getter above).
|
@longjon fixed function name. |
This was referenced Feb 14, 2018
|
Thanks for this @nitnelave, but a fuller interface has been exposed with the merge of #6238. Note that it includes c5b5b55 for the update test, with your authorship of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these additions, it becomes possible to use the solver to handle the learning rate while setting the inputs/diffs in python.