Update upstream #29
Merged
Update upstream #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #193 we moved setting of request headers to after setting the connection parameters (Content-Type header and request body). However, setting a request body (or more precisely, calling HttpUrlConection#getOutputStream) prevents us from setting additional headers, because the connection is opened already. Instead, we just skip setting the Content-Type header if one has already been set via Request#getHeaders. This is a bit more error-prone, but unlikely to change in the future, and hard to express in a cleaner way because with the DEPRECATED_GET_OR_POST method, we need to call getPostBody to determine if the request will be a GET or POST request, and we should only call this once. Verified on a real device (as Robolectric did not catch this). Fixes #198
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In google#193 we moved setting of request headers to after setting the
connection parameters (Content-Type header and request body).
However, setting a request body (or more precisely, calling
HttpUrlConection#getOutputStream) prevents us from setting
additional headers, because the connection is opened already.
Instead, we just skip setting the Content-Type header if one
has already been set via Request#getHeaders. This is a bit more
error-prone, but unlikely to change in the future, and hard to
express in a cleaner way because with the DEPRECATED_GET_OR_POST
method, we need to call getPostBody to determine if the request
will be a GET or POST request, and we should only call this once.
Verified on a real device (as Robolectric did not catch this).
Fixes google#198