fix(jpeg): Fix wrong pointers/crashing when decodng CMYK jpeg files #4963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was just wrong. Presumably broken recently. In the process, switched internal cmyk->rgb conversion to be span based. Fixes 4962 Signed-off-by: Larry Gritz <[email protected]>
Signed-off-by: Larry Gritz <[email protected]>
jessey-git
approved these changes
Nov 27, 2025
Contributor
jessey-git
left a comment
There was a problem hiding this comment.
Looks good to me and works with another cmyk file I produced locally. Thank you for adding that test.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Nov 27, 2025
…cademySoftwareFoundation#4963) Was just wrong. Presumably broken recently. In the process, switched internal cmyk->rgb conversion to be span based. Fixes AcademySoftwareFoundation#4962 --------- Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was just wrong. Presumably broken recently.
In the process, switched internal cmyk->rgb conversion to be span based.
Fixes #4962