build: For python stub generation, lock pybind11 #4831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.0 seems to break this process, so lock down to no later than the last version before it broke. Signed-off-by: Larry Gritz <[email protected]>
Collaborator
Author
Collaborator
Author
|
I got an offline approval from @chadrik on this patch, so merging now in order to fix our currently broken wheel CI. |
7e687aa
into
AcademySoftwareFoundation:main
134 of 136 checks passed
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jul 13, 2025
…oftwareFoundation#4831) pybind11 3.0 changed the generated stubs, causing CI to fail, so lock down to no later than the last version before it broke. We think the pybind11 3.0 generated stubs are mostly better, so at some point soon, when we have more time to look at it carefully, we will come back to this topic and bump our wheel workflow to use pybind11 3.0 and update the stubs accordintly. Signed-off-by: Larry Gritz <[email protected]>
zachlewis
pushed a commit
to zachlewis/OpenImageIO
that referenced
this pull request
Aug 1, 2025
…oftwareFoundation#4831) pybind11 3.0 changed the generated stubs, causing CI to fail, so lock down to no later than the last version before it broke. We think the pybind11 3.0 generated stubs are mostly better, so at some point soon, when we have more time to look at it carefully, we will come back to this topic and bump our wheel workflow to use pybind11 3.0 and update the stubs accordintly. Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pybind11 3.0 seems to break this process, so lock down to no later than the last version before it broke.