fix(oiiotool): fixes to --missingfile behavior #4803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some `oiiotool --missingfile` behavioral corner cases: When substituting, warn rather than making a true error. This didn't seem like a big deal for a single command line, but when doing a loop over frames, it would prevent correct behavior from pressing on to the next iteration. How big is the substitute image? It uses the rez and channels of the first image successfully read (if available). But it when in a frame loop, it resets this on every iteration, so any missing frame looks like it doesn't have a good size guess -- but it does, as long as it's not the first iteration of the loop. This involves safely gettingthe first image dimensions from the *parent* (each iteration is a child Oiiotool object). Signed-off-by: Larry Gritz <[email protected]>
AndreAnjosTD
approved these changes
Jun 17, 2025
There was a problem hiding this comment.
Tested the flag --missingfile with command:
oiiotool --parallel-frames --missingfile black -i path/to/sequence/render.#.exr --frames 1001-1200 --framepadding 4 --if "{SUBIMAGES > 1}" --subimage Beauty --endif --tocolorspace sRGB -o path/to/output/render.#.jpg
Our pipe worked with no issues after internal unit tests and production testing. This resolves missing frames as well as pixel reading errors, if used with #4804.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jun 18, 2025
…tion#4803) Fix some `oiiotool --missingfile` behavioral corner cases: When substituting, warn rather than making a true error. This didn't seem like a big deal for a single command line, but when doing a loop over frames, it would prevent correct behavior from pressing on to the next iteration. How big is the substitute image? It uses the rez and channels of the first image successfully read (if available). But it when in a frame loop, it resets this on every iteration, so any missing frame looks like it doesn't have a good size guess -- but it does, as long as it's not the first iteration of the loop. This involves safely gettingthe first image dimensions from the *parent* (each iteration is a child Oiiotool object). Signed-off-by: Larry Gritz <[email protected]>
zachlewis
pushed a commit
to zachlewis/OpenImageIO
that referenced
this pull request
Aug 1, 2025
…tion#4803) Fix some `oiiotool --missingfile` behavioral corner cases: When substituting, warn rather than making a true error. This didn't seem like a big deal for a single command line, but when doing a loop over frames, it would prevent correct behavior from pressing on to the next iteration. How big is the substitute image? It uses the rez and channels of the first image successfully read (if available). But it when in a frame loop, it resets this on every iteration, so any missing frame looks like it doesn't have a good size guess -- but it does, as long as it's not the first iteration of the loop. This involves safely gettingthe first image dimensions from the *parent* (each iteration is a child Oiiotool object). Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some
oiiotool --missingfilebehavioral corner cases:When substituting, warn rather than making a true error. This didn't seem like a big deal for a single command line, but when doing a loop over frames, it would prevent correct behavior from pressing on to the next iteration.
How big is the substitute image? It uses the rez and channels of the first image successfully read (if available). But it when in a frame loop, it resets this on every iteration, so any missing frame looks like it doesn't have a good size guess -- but it does, as long as it's not the first iteration of the loop. This involves safely gettingthe first image dimensions from the parent (each iteration is a child Oiiotool object).