api: Add new ImageInput::supports() query: "mipmap" #4800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Opinions? Since it's a new "supports" query, it should not break anything, though authors of any custom ImageInput subclasses are expected to return true for this query if they implemented a format that supports mipmaps. |
ImageOutput::supports() recognized queries for "multiimage" and "mipmap". But ImageInput::supports() only recognzied "multiimage". Add "mipmap" to make it easier for client software to know if the image file format they're reading from allows the possibility of MIPmapping. As far as I can tell, only OpenEXR, TIFF, Ptex, and DDS do, among the file types we currently support. Signed-off-by: Larry Gritz <[email protected]>
318232b to
76694d3
Compare
Collaborator
Author
|
I would like to merge this by the end of the week, if nobody objects. |
jessey-git
approved these changes
Jun 19, 2025
zachlewis
pushed a commit
to zachlewis/OpenImageIO
that referenced
this pull request
Aug 1, 2025
…oundation#4800) ImageOutput::supports() recognized queries for "multiimage" and "mipmap". But ImageInput::supports() only recognized "multiimage". Add "mipmap" to make it easier for client software to know if the image file format they're reading from allows the possibility of MIP-mapping. As far as I can tell, only OpenEXR, TIFF, Ptex, and DDS do, among the file types we currently support. Signed-off-by: Larry Gritz <[email protected]>
zachlewis
pushed a commit
to zachlewis/OpenImageIO
that referenced
this pull request
Sep 1, 2025
…oundation#4800) ImageOutput::supports() recognized queries for "multiimage" and "mipmap". But ImageInput::supports() only recognized "multiimage". Add "mipmap" to make it easier for client software to know if the image file format they're reading from allows the possibility of MIP-mapping. As far as I can tell, only OpenEXR, TIFF, Ptex, and DDS do, among the file types we currently support. Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageOutput::supports() recognized queries for "multiimage" and "mipmap". But ImageInput::supports() only recognized "multiimage". Add "mipmap" to make it easier for client software to know if the image file format they're reading from allows the possibility of MIP-mapping.
As far as I can tell, only OpenEXR, TIFF, Ptex, and DDS do, among the file types we currently support.