fix: clean up Windows compilation warnings #4706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Larry Gritz <[email protected]>
jessey-git
reviewed
Apr 22, 2025
Contributor
jessey-git
left a comment
There was a problem hiding this comment.
I can confirm that most* of the build warnings are gone for me locally. So this looks good from that angle.
*There's another set of warnings that have been popping up for me:
9>C:\Users\jesse\source\OpenImageIO\src\include\OpenImageIO\simd.h(6906,66): warning C4556: value of intrinsic immediate argument '8' is out of range '0 - 7'
9>(compiling source file '../../../src/iv/ivmain.cpp')
9>C:\Users\jesse\source\OpenImageIO\src\include\OpenImageIO\simd.h(8797,69): warning C4556: value of intrinsic immediate argument '8' is out of range '0 - 7'
9>(compiling source file '../../../src/iv/ivmain.cpp')
This is because we're feeding _MM_FROUND_NO_EXC into _mm_cvtps_ph and _mm256_cvtps_ph which isn't a valid value for that parameter:
https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html#text=_mm_cvtps_ph&ig_expand=2110,2107
https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html#text=_mm256_cvtps_ph&ig_expand=2110
Collaborator
Author
|
@jessey-git Thanks for the tip about simd.h. I will have a separate PR to address that. |
jessey-git
approved these changes
Apr 26, 2025
Contributor
jessey-git
left a comment
There was a problem hiding this comment.
All fine from my side.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Apr 26, 2025
…#4706) Signed-off-by: Larry Gritz <[email protected]>
scott-wilson
pushed a commit
to scott-wilson/OpenImageIO
that referenced
this pull request
May 17, 2025
…#4706) Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Scott Wilson <[email protected]>
scott-wilson
pushed a commit
to scott-wilson/OpenImageIO
that referenced
this pull request
May 18, 2025
…#4706) Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Scott Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.