Skip to content

Conversation

@louis4li
Copy link
Collaborator

@louis4li louis4li commented Feb 29, 2024

Close #3527

@vizipi
Copy link

vizipi bot commented Feb 29, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00% EanCuznaivy 200 8
100.00% jason-hoopox 25 8
75.00% 轩辕焮痕 1 6
62.50% gldeng 10 5
62.50% ZhangXin 10 5
50.00% kaiwenzhengaelf 4 4

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
...contract/AElf.Contracts.Election/ElectionContract_Elector66.67%4 out of 6 times
contract/AElf.Contracts.MultiToken/TokenContract_Actions.cs66.67%4 out of 6 times
contract/AElf.Contracts.Treasury/TreasuryContract.cs66.67%4 out of 6 times
protobuf/token_contract.proto66.67%4 out of 6 times
test/AElf.Contracts.Election.Tests/BVT/ElectionTests.cs66.67%4 out of 6 times
protobuf/election_contract.proto66.67%4 out of 6 times
contract/AElf.Contracts.Consensus.AEDPoS/AEDPoSContract.cs66.67%4 out of 6 times
...contract/AElf.Contracts.Election/ElectionContract_Maintai66.67%4 out of 6 times
test/AElf.Contracts.Profit.Tests/ProfitContractTestBase.cs66.67%4 out of 6 times
test/AElf.Contracts.TestBase/ContractTester.cs66.67%4 out of 6 times

Committed file ranks

(click to expand)
  • 99.75%[contract/AElf.Contracts.Profit/ProfitContract.cs]
  • 98.55%[protobuf/profit_contract.proto]
  • 94.02%[contract/AElf.Contracts.Profit/ProfitContractState.cs]
  • 82.34%[contract/AElf.Contracts.Profit/ProfitContractConstants.cs]
  • 96.75%[contract/AElf.Contracts.Profit/ViewMethods.cs]
  • 97.34%[...test/AElf.Contracts.Election.Tests/Full/ReleaseProfitsFro]
  • 98.73%[test/AElf.Contracts.Profit.Tests/ProfitTests.cs]
  • 70.80%[...test/AElf.Contracts.Profit.Tests/ProfitContractTestConsta]
  • @jason-aelf jason-aelf changed the title Release/1.7.0 Release v1.7.0 Feb 29, 2024
    @vizipi vizipi bot requested a review from jason-aelf February 29, 2024 09:51
    @codecov
    Copy link

    codecov bot commented Feb 29, 2024

    Codecov Report

    All modified and coverable lines are covered by tests ✅

    Project coverage is 90.69%. Comparing base (7541806) to head (0c8e1dc).

    Additional details and impacted files

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##           master    #3526      +/-   ##
    ==========================================
    + Coverage   90.66%   90.69%   +0.03%     
    ==========================================
      Files         663      663              
      Lines       25458    25500      +42     
      Branches     2285     2287       +2     
    ==========================================
    + Hits        23082    23128      +46     
    + Misses       2260     2256       -4     
      Partials      116      116              
    Files Coverage Δ
    contract/AElf.Contracts.Profit/ProfitContract.cs 93.80% <100.00%> (+0.21%) ⬆️
    contract/AElf.Contracts.Profit/ViewMethods.cs 99.03% <100.00%> (+4.99%) ⬆️

    @jason-aelf jason-aelf merged commit 2d30519 into master Feb 29, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants