tests: make functional_tests.sh configurable #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to run functional_tests.sh with different parameters, make it configurable by environment variables, like RG, LOCATION, VM_SIZE. For example, it is now possible to simply run like below, without having to manually update variables in the script: ``` RG="my-test-azinit" LOCATION="germanywestcentral" \ VM_SIZE="Standard_DS3_v2" make e2e-test ``` Also update the default RG name to "e2etest-azinit", VM_NAME to "AzInitFunctionalTest".
44139e3 to
968da03
Compare
Collaborator
Author
|
Hmm, interesting, it is not sufficient for Jeremy to approve this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to run
functional_tests.shwith different parameters, make it configurable by environment variables, likeRG,LOCATION,VM_SIZE.For example, it is now possible to simply run like below, without having to manually update variables in the script:
Also update the default RG name to
e2etest-azinit, VM_NAME toAzInitFunctionalTest.Testing done
Tested in Azure.