This repository was archived by the owner on Jul 10, 2025. It is now read-only.
Stories library part 8 - MetaDataProvider #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvice and returned when a StorySaveResult is ready
|
You can test the changes on this Pull Request by downloading the APK here. |
Base automatically changed from
feature/wp-stories-part6-mediapicker-wpmedia3-intent-loader
to
feature/273-save-frame-service-base
June 19, 2020 19:10
jd-alexander
approved these changes
Jun 19, 2020
There was a problem hiding this comment.
Thanks for these changes @mzorz Tested it and it works well! LGTM 🚢
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #351
This PR adds the
MetadataProviderinterface so payload can be injected to the service and returned when aStorySaveResultis ready and broadcasted through EventBus.In general, the host app may need to set some state variable values in a Bundle that it can retrieve later when a Story is finished saving. For example in WPAndroid, it may be useful to set the currently selected
SiteModelthe Story is supposed to be uploaded to, and as such once a SaveResult is received even if context has changed (i.e. even if the user saved a Story and then switched to work on another site), so it can properly proceed and do whatever it needs to correctly interpret the results once these are received.To test:
Payload is: example metadata