This repository was archived by the owner on Jul 10, 2025. It is now read-only.
Stories library part 8.2 - introduces interface StoryDiscardListener #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test the changes on this Pull Request by downloading the APK here. |
Base automatically changed from
feature/wp-stories-part81-add-file-result
to
feature/273-save-frame-service-base
June 19, 2020 20:23
jd-alexander
approved these changes
Jun 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #354
Related WPAndroid PR: wordpress-mobile/WordPress-Android#12031
(this means the WPAndroid PR points to this branch)
This PR adds a simple interface to signal listeners when the ComposeLoopFrameActivity has been abandoned without any Story being saved at all (i.e. pressing
backon the camera preview screen while current Story in the StoryRepository has zero frames).Comes in handy for listeners to do any cleanup they might need.
To test:
"Story has been discarded!"is shown (this means the listener interface worked)