Skip to content

Conversation

@srijanravisankar
Copy link

@srijanravisankar srijanravisankar commented Nov 3, 2025

Description

This PR adds a theme toggle button to the Projects page header for UI consistency with the editor page and landing page.
I imported and used next to project action buttons. This maintains consistent placement and styling. I have verified that dark/light mode toggles correctly.

Fixes #646

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Verified that dark/light mode toggles correctly for desktop layout.

Test Configuration:

  • Node version: v24.11.0
  • Browser (if applicable): Brave
  • Operating System: Windows

Screenshots (if applicable)

Add screenshots to help explain your changes.
Before:
Screenshot 2025-11-02 193915
After:
Screenshot 2025-11-02 193855

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have added screenshots if ui has been changed
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

Testing:

opencut-toggle-feature-for-projects-page-testing.mp4

Summary by CodeRabbit

  • New Features
    • Added a theme toggle button to the Projects page header, allowing users to easily switch between light and dark modes directly from the projects view.

@netlify
Copy link

netlify bot commented Nov 3, 2025

👷 Deploy request for appcut pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit d5e272e

@vercel
Copy link

vercel bot commented Nov 3, 2025

@srijanravisankar is attempting to deploy a commit to the OpenCut OSS Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 3, 2025

Walkthrough

Added the ThemeToggle component to the Projects page header in non-selection mode. The existing Theme Toggle UI component was imported and rendered alongside other header elements without modifying business logic or data flow.

Changes

Cohort / File(s) Summary
Theme Toggle UI Addition
apps/web/src/app/projects/page.tsx
Imported ThemeToggle component and rendered it in the Projects page header area (non-selection mode). No logic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single file with import and component rendering addition
  • No logic modifications or conditional complexity
  • Reuses existing, proven component
  • No test changes or side effects

Poem

🐰 A toggle for themes now brightens the way,
Dark mode and light dance through Projects all day,
Where once there was grey, now choices abound,
The Projects page blooms with colors so sound! ✨

Pre-merge checks and finishing touches

✅ Passed checks (4 passed)
Check name Status Explanation
Title Check ✅ Passed The title "feat: add theme toggle to Projects page header" directly and accurately describes the main change in the pull request. It follows conventional commit format, is concise and specific, and clearly communicates that a theme toggle component was added to the Projects page header. A teammate scanning the commit history would immediately understand the primary change without ambiguity.
Linked Issues Check ✅ Passed The code changes meet all primary objectives from the linked issue #646. The implementation correctly reuses the existing ThemeToggle component and adds it to the Projects page header next to action buttons as required. The raw summary confirms the component was imported and rendered in the header area with no changes to business logic, and the PR description documents verification that dark/light mode toggle functionality works correctly. The placement and styling align with how the component is used on the editor and landing pages, meeting the consistency requirement.
Out of Scope Changes Check ✅ Passed All changes in this pull request are directly scoped to the linked issue #646. The modifications consist solely of importing and rendering the ThemeToggle component in the Projects page header, with no business logic changes or modifications to unrelated functionality. The raw summary indicates that no exported or public entity signatures were modified, and the change is limited to UI addition in the appropriate location. No extraneous or tangentially related changes are present.
Description Check ✅ Passed The pull request description follows the repository's template structure with all critical sections completed. It includes a clear description of changes, the related issue fix (#646), the correct type of change selection (New feature), detailed test configuration (Node v24.11.0, Brave browser, Windows), before/after screenshots, and a comprehensive checklist with most items marked complete. While some checklist items are unchecked (documentation update, code comments, dependent changes), these appear intentionally deferred and do not prevent the description from meeting the template requirements.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)
apps/web/src/app/projects/page.tsx (2)

95-95: Remove console.log statement.

This debug statement violates the coding guideline prohibiting console usage in production code.

Apply this diff:

 const handleCreateProject = async () => {
   const projectId = await createNewProject("New Project");
-  console.log("projectId", projectId);
   router.push(`/editor/${projectId}`);
 };

68-91: Include thumbnailCache in the dependency array.

The getProjectThumbnail callback accesses thumbnailCache (line 70) but doesn't list it as a dependency. This can lead to stale closures where the callback captures an outdated version of the cache.

Apply this diff:

 const getProjectThumbnail = useCallback(
   async (projectId: string): Promise<string | null> => {
     if (thumbnailCache[projectId] !== undefined) {
       return thumbnailCache[projectId];
     }

     setLoadingThumbnails((prev) => new Set(prev).add(projectId));

     try {
       const thumbnail = await useTimelineStore
         .getState()
         .getProjectThumbnail(projectId);
       setThumbnailCache((prev) => ({ ...prev, [projectId]: thumbnail }));
       return thumbnail;
     } finally {
       setLoadingThumbnails((prev) => {
         const newSet = new Set(prev);
         newSet.delete(projectId);
         return newSet;
       });
     }
   },
-  []
+  [thumbnailCache]
 );

Based on learnings.

🧹 Nitpick comments (1)
apps/web/src/app/projects/page.tsx (1)

219-219: Ensure ThemeToggle visibility is consistent across pages, or document the intentional difference.

The ThemeToggle is desktop-only on the Projects page (hidden md:block), but is visible on all screen sizes in the landing page (header.tsx, line 44) and editor page (editor-header.tsx, line 119). Either add ThemeToggle to the mobile view here for consistency, or document why it is intentionally desktop-only on this page.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bee7aba and d5e272e.

📒 Files selected for processing (1)
  • apps/web/src/app/projects/page.tsx (2 hunks)
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{jsx,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{jsx,tsx}: Don't use accessKey attribute on any HTML element.
Don't set aria-hidden="true" on focusable elements.
Don't add ARIA roles, states, and properties to elements that don't support them.
Don't use distracting elements like <marquee> or <blink>.
Only use the scope prop on <th> elements.
Don't assign non-interactive ARIA roles to interactive HTML elements.
Make sure label elements have text content and are associated with an input.
Don't assign interactive ARIA roles to non-interactive HTML elements.
Don't assign tabIndex to non-interactive HTML elements.
Don't use positive integers for tabIndex property.
Don't include "image", "picture", or "photo" in img alt prop.
Don't use explicit role property that's the same as the implicit/default role.
Make static elements with click handlers use a valid role attribute.
Always include a title element for SVG elements.
Give all elements requiring alt text meaningful information for screen readers.
Make sure anchors have content that's accessible to screen readers.
Assign tabIndex to non-interactive HTML elements with aria-activedescendant.
Include all required ARIA attributes for elements with ARIA roles.
Make sure ARIA properties are valid for the element's supported roles.
Always include a type attribute for button elements.
Make elements with interactive roles and handlers focusable.
Give heading elements content that's accessible to screen readers (not hidden with aria-hidden).
Always include a lang attribute on the html element.
Always include a title attribute for iframe elements.
Accompany onClick with at least one of: onKeyUp, onKeyDown, or onKeyPress.
Accompany onMouseOver/onMouseOut with onFocus/onBlur.
Include caption tracks for audio and video elements.
Use semantic elements instead of role attributes in JSX.
Make sure all anchors are valid and navigable.
Ensure all ARIA properties (aria-*) are valid.
Use valid, non-abstract ARIA roles for elements with...

Files:

  • apps/web/src/app/projects/page.tsx
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{ts,tsx}: Don't use TypeScript enums.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use TypeScript namespaces.
Don't use non-null assertions with the ! postfix operator.
Don't use parameter properties in class constructors.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use either T[] or Array<T> consistently.
Initialize each enum member value explicitly.
Use export type for types.
Use import type for types.
Make sure all enum members are literal values.
Don't use TypeScript const enum.
Don't declare empty interfaces.
Don't let variables evolve into any type through reassignments.
Don't use the any type.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use implicit any type on variable declarations.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use the TypeScript directive @ts-ignore.
Use consistent accessibility modifiers on class properties and methods.
Use function types instead of object types with call signatures.
Don't use void type outside of generic or return types.

**/*.{ts,tsx}: Don't use primitive type aliases or misleading types
Don't use the TypeScript directive @ts-ignore
Don't use TypeScript enums
Use either T[] or Array consistently
Don't use the any type

Files:

  • apps/web/src/app/projects/page.tsx
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{js,jsx,ts,tsx}: Don't use the return value of React.render.
Don't use consecutive spaces in regular expression literals.
Don't use the arguments object.
Don't use primitive type aliases or misleading types.
Don't use the comma operator.
Don't write functions that exceed a given Cognitive Complexity score.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names that aren't base 10 or use underscore separators.
Remove redundant terms from logical expressions.
Use while loops instead of...

Files:

  • apps/web/src/app/projects/page.tsx
**/*.{tsx,jsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

**/*.{tsx,jsx}: Always include a title element for icons unless there's text beside the icon
Always include a type attribute for button elements
Accompany onClick with at least one of: onKeyUp, onKeyDown, or onKeyPress
Accompany onMouseOver/onMouseOut with onFocus/onBlur
Don't import React itself
Don't define React components inside other components
Don't use both children and dangerouslySetInnerHTML on the same element
Don't insert comments as text nodes
Use <>...</> instead of ...

Files:

  • apps/web/src/app/projects/page.tsx
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

**/*.{ts,tsx,js,jsx}: Don't use the comma operator
Use for...of statements instead of Array.forEach
Don't initialize variables to undefined
Use .flatMap() instead of map().flat() when possible
Don't assign a value to itself
Avoid unused imports and variables
Don't use await inside loops
Don't hardcode sensitive data like API keys and tokens
Don't use the delete operator
Don't use global eval()
Use String.slice() instead of String.substr() and String.substring()
Don't use else blocks when the if block breaks early
Put default function parameters and optional function parameters last
Use new when throwing an error
Use String.trimStart() and String.trimEnd() over String.trimLeft() and String.trimRight()

Files:

  • apps/web/src/app/projects/page.tsx
🧠 Learnings (1)
📚 Learning: 2025-08-09T09:03:49.797Z
Learnt from: CR
Repo: OpenCut-app/OpenCut PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-08-09T09:03:49.797Z
Learning: Applies to **/*.{jsx,tsx} : Make sure all dependencies are correctly specified in React hooks.

Applied to files:

  • apps/web/src/app/projects/page.tsx
🧬 Code graph analysis (1)
apps/web/src/app/projects/page.tsx (1)
apps/web/src/components/theme-toggle.tsx (1)
  • ThemeToggle (11-25)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Vercel Agent Review
🔇 Additional comments (1)
apps/web/src/app/projects/page.tsx (1)

21-21: LGTM!

The import statement follows the project's conventions and is correctly placed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add theme toggle button to Projects page

1 participant