Adding uniqueId and includeOrder #190
Conversation
…gaard-includeOrder
CodeSee Review Map:Review in an interactive map View more CodeSee Maps Legend |
|
thanks! I'll be looking into this this coming Saturday. Sorry for the delay! |
|
@izar any news? |
|
SO sorry! Work is crazy these days and I can't find a minute to get to this. It is on the top of the pile though. |
|
hi @per-oestergaard - tests are failing, apparently the Element names are not matching. Functionality seems OK, just the tests. Can you take a look please? |
|
@izar is this still an issue? @'
cd /pwd
ls -l
pip install -r requirements-dev.txt
pip install -r requirements.txt
pwd
python3 -m unittest -v tests/test_pytmfunc.py
ls
'@ | set-content x.sh -NoNewline; docker run --rm -v "${pwd}:/pwd" python bash /pwd/x.shAll tests passes |
|
It seems to still be an issue: ======================================================================
|
I want to have stable references so I can synchronize the findings with an risk management tool and make the model a living document. To do so, I allow includeOrder to be set on any component (Actor etc.) and when that is set and the order is specified (not -1), the name is changed to contain the order and the findings are containing the order as well.
In this version, there is no validation of whether the order is unique. That is up to the person writing the Python to ensure that.
On finding object's UniqueId: When order is present and includeOrder is true on the object, this will be formatted as findingId:order. E.g. if finding is INP01 and order is 123, the value becomes INP01:123."
On object's includeOrder: If True and Order is set (not -1), the displayed name will be formatted as 'order:name'. If you make Order unique, this will give you a stable reference you can use for synchronization etc.