Skip to content

produce stable diagrams #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2020
Merged

produce stable diagrams #79

merged 1 commit into from
Mar 4, 2020

Conversation

@nineinchnick
Copy link
Collaborator

The sequence image file generated using plantuml is changing on every run. If this file is commited to a repository together with the model it's slightly annoying to see it in diffs of every commit, although the model did not change. This PR switches from using UUIDv4 to a generic UUID that would respect setting a seed.

Added unit tests for generated dfd and seq. Verified additionally using:

$ make report
mkdir -p tm
./tm.py --dfd | dot -Tpng -o tm/dfd.png
./tm.py --seq | java -Djava.awt.headless=true -jar ./plantuml.jar -tpng -pipe > tm/seq.png
./tm.py --report docs/template.md | pandoc -f markdown -t html > tm/report.html
$ cp tm/seq.png tm/seq2.png
$ make report
mkdir -p tm
./tm.py --dfd | dot -Tpng -o tm/dfd.png
./tm.py --seq | java -Djava.awt.headless=true -jar ./plantuml.jar -tpng -pipe > tm/seq.png
./tm.py --report docs/template.md | pandoc -f markdown -t html > tm/report.html
$ md5sum tm/seq.png tm/seq2.png
6c7381e51004ec38bbe4a7522900f37b  tm/seq.png
6c7381e51004ec38bbe4a7522900f37b  tm/seq2.png

@nineinchnick nineinchnick requested a review from izar as a code owner February 29, 2020 21:09
@ghost
Copy link

ghost commented Feb 29, 2020 •
edited by ghost
Loading

DeepCode's analysis on #77ad7d found:

  • ❌ 0 critical issues. ⚠️ 0 warnings and 5 minor issues. ✔️ 2 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.

☺️ If you want to provide feedback on our bot, here is how to contact us.

@izar
Copy link
Collaborator

izar commented Mar 4, 2020

Great catch, thanks!

@izar izar merged commit bd8f5ab into OWASP:master Mar 4, 2020
@nineinchnick nineinchnick deleted the stable-output branch March 12, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@izar izar Awaiting requested review from izar izar is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nineinchnick @izar