Skip to content

allow setting properties on init #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2020
Merged

allow setting properties on init #67

merged 1 commit into from
Feb 11, 2020

Conversation

@nineinchnick
Copy link
Collaborator

For elements/flows that have very few properties:

webserver = Server("web server", inBoundary=internal)
request = Dataflow(user, webserver, "some request", dstPort=443)

For elements/flows with some common props:

props = {
    "dstPort": 443,
    "protocol": "HTTPS",
}
login = Dataflow(user, webserver, "first request", **props)
do_stuff = Dataflow(user, webserver, "second request", **props)

@nineinchnick nineinchnick requested a review from izar as a code owner February 8, 2020 15:12
@ghost
Copy link

ghost commented Feb 8, 2020

DeepCode's analysis on #05d324 found:

  • ❌ 0 critical issues. ⚠️ 0 warnings and 0 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.

☺️ If you want to provide feedback on our bot, here is how to contact us.

izar
izar approved these changes Feb 11, 2020
View reviewed changes
Copy link
Collaborator

@izar izar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, these patches add a lot of value. This one specially, I can see it opening the door for JSON-defined objects, taking it even one step further.

@izar izar merged commit 30f8095 into OWASP:master Feb 11, 2020
@nineinchnick nineinchnick deleted the init-with-kwargs branch March 12, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@izar izar izar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nineinchnick @izar