Skip to content

Conversation

@davidye007
Copy link
Contributor

Added eBird to West Cascades project. Branding and aesthetic improvements.

fixes #280, #279, #252, #219, #188, #214, #72,

@davidye007 davidye007 requested review from EmiliaH and sgwinder April 30, 2025 07:00
@davidye007
Copy link
Contributor Author

Hey @sgwinder @EmiliaH, this PR including branding and aesthetic changes, and I've also included eBird in the West Cascades project. Please take a look around, and let me know if you have any concerns/suggestions. Thanks a lot!

@sgwinder
Copy link
Member

Nice @davidye007 , this looks really good! I like the colors.

The bear is very cute :-).

I noticed a typo in the note about home locations: Note: Chatbot data does not include internaitonal visitors. International is misspelled.

On the info source tab, would you please change the x axis title to be "Number of Respondents" and "Percent of Respondents" rather than "Count" and "%"? I think this would be a helpful change on the Party Characteristic barcharts, too.

I checked out everything except for the "compare site" colors, since I still can't get this function to work on my mac (Issue #286). Would you mind adding a screenshot of this comparison?

Thanks!

@davidye007
Copy link
Contributor Author

davidye007 commented Apr 30, 2025

@sgwinder Thank you for the thoughtful review! I made the corrections and updates based of your comments.

Below are some screenshots of site comparison colors:
image
image
image

Let me know if they look good with you!

Copy link
Member

@EmiliaH EmiliaH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @davidye007! Merge away unless @sgwinder has anything else!

y: {
label: {
text: displayMode === '%' ? '%' : 'Count',
text: displayMode === '%' ? 'Percent of Respondents' : 'Number of Respondents',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind it was my problem... had a temporary moment where I forgot where the y axis was!

@davidye007
Copy link
Contributor Author

@EmiliaH Thanks for the review and that sounds good to me! I'll merge it in :D

@davidye007 davidye007 merged commit 5bddbb6 into master May 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve layout of the party characteristics data visualizations.

4 participants