-
Notifications
You must be signed in to change notification settings - Fork 3
Aesthetics and eBird #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aesthetics and eBird #289
Conversation
…nal visitors, fix legend background color
|
Nice @davidye007 , this looks really good! I like the colors. The bear is very cute :-). I noticed a typo in the note about home locations: On the info source tab, would you please change the x axis title to be "Number of Respondents" and "Percent of Respondents" rather than "Count" and "%"? I think this would be a helpful change on the Party Characteristic barcharts, too. I checked out everything except for the "compare site" colors, since I still can't get this function to work on my mac (Issue #286). Would you mind adding a screenshot of this comparison? Thanks! |
|
@sgwinder Thank you for the thoughtful review! I made the corrections and updates based of your comments. Below are some screenshots of site comparison colors: Let me know if they look good with you! |
EmiliaH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @davidye007! Merge away unless @sgwinder has anything else!
| y: { | ||
| label: { | ||
| text: displayMode === '%' ? '%' : 'Count', | ||
| text: displayMode === '%' ? 'Percent of Respondents' : 'Number of Respondents', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind it was my problem... had a temporary moment where I forgot where the y axis was!
|
@EmiliaH Thanks for the review and that sounds good to me! I'll merge it in :D |
Added eBird to West Cascades project. Branding and aesthetic improvements.
fixes #280, #279, #252, #219, #188, #214, #72,