Skip to content

Conversation

@amousset
Copy link
Member

@amousset amousset commented Aug 27, 2025

https://issues.rudder.io/issues/27451

Webapp side:

  • Adds a new global "HTTPS only" option
  • Renames "secure validation" / "cert name validation" to "cert validation"
  • Change the bahvior of the ca setting to load the content of the PEM file instead of passing the file path (this provides the value on nodes)

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset amousset changed the title Fixes #27451: Make the apache config configurable Fixes #27451: Allow configuring the HTTPS certificates Aug 28, 2025
Fixes #27451: Allow configuring the certificates
@amousset
Copy link
Member Author

amousset commented Sep 2, 2025

PR updated with a new commit

@amousset amousset marked this pull request as ready for review September 2, 2025 08:06
@amousset
Copy link
Member Author

amousset commented Sep 2, 2025

TODO minijinja

AUDIT="false"

define_class() {
echo "+$1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is it used for ?

Fixes #27451: Allow configuring the certificates
@amousset
Copy link
Member Author

amousset commented Sep 3, 2025

PR updated with a new commit

…igurable

Fixes #27451: Allow configuring the certificates
@amousset
Copy link
Member Author

amousset commented Sep 4, 2025

PR updated with a new commit

…ig configurable

Fixes #27451: Allow configuring the certificates
@amousset
Copy link
Member Author

amousset commented Sep 4, 2025

PR updated with a new commit

…he config configurable

Fixes #27451: Allow configuring the certificates
@amousset
Copy link
Member Author

amousset commented Sep 4, 2025

PR updated with a new commit

…he apache config configurable

Fixes #27451: Allow configuring the certificates
@amousset
Copy link
Member Author

amousset commented Sep 4, 2025

PR updated with a new commit

… Make the apache config configurable

Fixes #27451: Allow configuring the certificates
@amousset
Copy link
Member Author

amousset commented Sep 4, 2025

PR updated with a new commit

…#27451: Make the apache config configurable

Fixes #27451: Allow configuring the certificates
@amousset
Copy link
Member Author

amousset commented Sep 4, 2025

PR updated with a new commit

… Fixes #27451: Make the apache config configurable

Fixes #27451: Allow configuring the certificates
@amousset
Copy link
Member Author

amousset commented Sep 4, 2025

PR updated with a new commit

#
# Does hash comparison to avoid useless downloads.

# Uses the CFEngine module protocol.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really ?
it is called with commands:

"${report_data.method_id}" usebundle => log_rudder_v4("${path}", "Copying ${path} from ${source}", "");

commands:
pass2.!pass3.rudder_https_only::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't the logging missing ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is, this method does not work for noz

SSLCACertificateFile /var/rudder/lib/ssl/policy_server_ca.pem
{% endif %}

{% if classes.rudder_cert_validation is not defined %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if classes.rudder_cert_validation is defined but not vars.custom_ca_path there will be no SSLCACertificateFile i don't thinks that's expected

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK it uses the system CA store when no value is provided.

Copy link
Member

@fanf fanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scala parts seem good.

… fixup! Fixes #27451: Make the apache config configurable

Fixes #27451: Allow configuring the certificates
@amousset
Copy link
Member Author

amousset commented Sep 4, 2025

PR updated with a new commit

@amousset
Copy link
Member Author

amousset commented Sep 4, 2025

Merging to be able to test the whole thing. I'll fix the file from shared folder method in an upcoming PR.

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/6575
-- Your faithful QA
Kant merge: "Happiness is not an ideal of reason, but of imagination."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/106740/console)

… fixup! fixup! Fixes #27451: Make the apache config configurable

Fixes #27451: Allow configuring the certificates
@amousset
Copy link
Member Author

amousset commented Sep 4, 2025

PR updated with a new commit

@amousset amousset merged commit 046c6a6 into Normation:branches/rudder/9.0 Sep 4, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants