-
Notifications
You must be signed in to change notification settings - Fork 85
Fixes #27451: Allow configuring the HTTPS certificates #6575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #27451: Allow configuring the HTTPS certificates #6575
Conversation
Fixes #27451: Make the apache config configurable
|
PR updated with a new commit |
Fixes #27451: Allow configuring the certificates
|
PR updated with a new commit |
|
TODO minijinja |
| AUDIT="false" | ||
|
|
||
| define_class() { | ||
| echo "+$1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is it used for ?
Fixes #27451: Allow configuring the certificates
|
PR updated with a new commit |
…igurable Fixes #27451: Allow configuring the certificates
|
PR updated with a new commit |
…ig configurable Fixes #27451: Allow configuring the certificates
|
PR updated with a new commit |
…he config configurable Fixes #27451: Allow configuring the certificates
|
PR updated with a new commit |
…he apache config configurable Fixes #27451: Allow configuring the certificates
|
PR updated with a new commit |
… Make the apache config configurable Fixes #27451: Allow configuring the certificates
|
PR updated with a new commit |
…#27451: Make the apache config configurable Fixes #27451: Allow configuring the certificates
|
PR updated with a new commit |
… Fixes #27451: Make the apache config configurable Fixes #27451: Allow configuring the certificates
|
PR updated with a new commit |
| # | ||
| # Does hash comparison to avoid useless downloads. | ||
|
|
||
| # Uses the CFEngine module protocol. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really ?
it is called with commands:
| "${report_data.method_id}" usebundle => log_rudder_v4("${path}", "Copying ${path} from ${source}", ""); | ||
|
|
||
| commands: | ||
| pass2.!pass3.rudder_https_only:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't the logging missing ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is, this method does not work for noz
| SSLCACertificateFile /var/rudder/lib/ssl/policy_server_ca.pem | ||
| {% endif %} | ||
|
|
||
| {% if classes.rudder_cert_validation is not defined %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if classes.rudder_cert_validation is defined but not vars.custom_ca_path there will be no SSLCACertificateFile i don't thinks that's expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK it uses the system CA store when no value is provided.
fanf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scala parts seem good.
… fixup! Fixes #27451: Make the apache config configurable Fixes #27451: Allow configuring the certificates
|
PR updated with a new commit |
|
Merging to be able to test the whole thing. I'll fix the file from shared folder method in an upcoming PR. |
|
This PR is not mergeable to upper versions. |
… fixup! fixup! Fixes #27451: Make the apache config configurable Fixes #27451: Allow configuring the certificates
|
PR updated with a new commit |
https://issues.rudder.io/issues/27451
Webapp side:
casetting to load the content of the PEM file instead of passing the file path (this provides the value on nodes)