Fixes #27218: Adding command module #6506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
PR updated with a new commit |
1 similar comment
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
13 similar comments
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
amousset
reviewed
Jul 22, 2025
Contributor
Author
|
PR updated with a new commit |
11 similar comments
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
… fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Fixes #27218: Adding command module Fixes #27218: Adding command module
… fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Fixes #27218: Adding command module Fixes #27218: Adding command module
… fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Fixes #27218: Adding command module Fixes #27218: Adding command module
… fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Fixes #27218: Adding command module Fixes #27218: Adding command module
… fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Fixes #27218: Adding command module Fixes #27218: Adding command module
… fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Fixes #27218: Adding command module Fixes #27218: Adding command module
… fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Fixes #27218: Adding command module Fixes #27218: Adding command module
… fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Fixes #27218: Adding command module Fixes #27218: Adding command module
1eed95a to
c439203
Compare
… fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Fixes #27218: Adding command module Fixes #27218: Adding command module
Contributor
Author
|
PR updated with a new commit |
amousset
reviewed
Aug 19, 2025
amousset
reviewed
Aug 19, 2025
amousset
reviewed
Aug 19, 2025
… fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Fixes #27218: Adding command module Fixes #27218: Adding command module
Contributor
Author
|
PR updated with a new commit |
Fdall
reviewed
Aug 20, 2025
Fdall
reviewed
Aug 20, 2025
| default: false | ||
| p_type: bool | ||
| in_shell: | ||
| description: "Controls if the command is executed inside a shell" |
Contributor
There was a problem hiding this comment.
Does it support piping? If so, provides an example, I was unable to make it work using the CLI
Contributor
Author
There was a problem hiding this comment.
Yes, but quotes are required when using the CLI in shell mode.
$ rudder-module-commands --in-shell "echo HELLO | cat -"
Member
There was a problem hiding this comment.
The standard way to handle this is to support the -- syntax to stop parsing argument. But the current state seems acceptable.
Fdall
reviewed
Aug 20, 2025
… fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Fixes #27218: Adding command module Fixes #27218: Adding command module
Contributor
Author
|
PR updated with a new commit |
… fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Fixes #27218: Adding command module Fixes #27218: Adding command module
Contributor
Author
|
PR updated with a new commit |
amousset
reviewed
Aug 20, 2025
… fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Fixes #27218: Adding command module Fixes #27218: Adding command module
Contributor
Author
|
PR updated with a new commit |
amousset
approved these changes
Aug 20, 2025
… fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Fixes #27218: Adding command module Fixes #27218: Adding command module
Contributor
Author
|
PR updated with a new commit |
3fe6665
into
Normation:branches/rudder/9.0
5 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/27218