Skip to content

Fixes #27173: Add and Remove/deprecate API for Rudder 9.0 - version 22 #6484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

Fixes #27173: Add and Remove/deprecate API for Rudder 9.0 - version 22 #6484

merged 1 commit into from
Jul 1, 2025

Conversation

@fanf
Copy link
Member

@fanf fanf commented Jun 30, 2025 •
edited
Loading

https://issues.rudder.io/issues/27173

  • move currently supported API versions from RudderConfig to a dedicated object SupportedApiVersions in rudder-core
  • use these value by default in tests, so that we can check that we correctly support the last version (without doing anything)
  • remove deprecated versions < 21 (ie, keep Rudder 8.3 and up)
  • remove code used for compatibility in older, deleted versions (old node format, old allowed networks, old system info, etc)
  • add documentation for API version 21 (Rudder 8.3) and 22 (Rudder 9.0)

@fanf fanf requested a review from VinceMacBuche June 30, 2025 16:51
@fanf fanf marked this pull request as draft June 30, 2025 16:55
@fanf
Copy link
Member Author

fanf commented Jun 30, 2025

PR updated with a new commit

@fanf fanf force-pushed the arch_27173/add_and_remove_deprecate_api_for_rudder_9_0_version_22 branch from 4c5827e to 6cb131e Compare June 30, 2025 19:25
@fanf fanf marked this pull request as ready for review June 30, 2025 19:26
clarktsiory
clarktsiory approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@clarktsiory clarktsiory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice code deletion !

@Normation-Quality-Assistant
Copy link
Contributor

Normation-Quality-Assistant commented Jul 1, 2025

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 6cb131e into Normation:branches/rudder/9.0 Jul 1, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clarktsiory clarktsiory clarktsiory approved these changes

@VinceMacBuche VinceMacBuche Awaiting requested review from VinceMacBuche

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fanf @Normation-Quality-Assistant @clarktsiory