Skip to content

Conversation

@fanf
Copy link
Member

@fanf fanf commented Jun 23, 2025

https://issues.rudder.io/issues/27153

Some cleaning-up in campaign code:

  • use standard layout for CampaignEventState (case object/class in object CampaignEventState)
  • create enums for query parameters in place of string: CampaignSortOrder, CampaignSortDirection
  • factor out default value for CampaignSortOrder in pattern matching
  • use the actual CampaignEventState in place of its string value in query
  • remove MainCampaignService from CampaignHandler which is not used and create a dependency loop

Replaces #6424
Needed for https://github.com/Normation/rudder-plugins-private/pull/1038

@fanf fanf requested review from clarktsiory and removed request for clarktsiory June 23, 2025 21:15
@fanf fanf marked this pull request as draft June 23, 2025 21:17
@fanf fanf marked this pull request as ready for review June 24, 2025 10:27
@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 0d979d0 into Normation:branches/rudder/9.0 Jul 3, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants