ocamlPackages.yojson: 2.2.2 → 3.0.0 #470071
Conversation
ocamlPackages.atdgen-codec-runtime: 2.16.0 → 3.0.1
|
marijanp
left a comment
There was a problem hiding this comment.
LGTM. why3find seems to have a flaky test
There was a problem hiding this comment.
I would have prefered to have changes like this broken out in separate commits. It makes the review process easier. But I understand that this all belongs together ultimately :)
|
|
||
| yojson_2 = yojson.overrideAttrs (_: { | ||
| version = "2.2.2"; | ||
| __intentionallyOverridingVersion = true; |
There was a problem hiding this comment.
Out of curiosity, why is this needed? I would never override unintentionally 🤷♂️
There was a problem hiding this comment.
this is to suppress a warning msg
|
| patches = [ | ||
| # Compatibility with yojson 3.0 | ||
| (fetchpatch { | ||
| url = "https://github.com/mirage/ocaml-github/commit/487d7d413363921a8ffbb941610c2f71c811add8.patch"; | ||
| hash = "sha256-ThCsWRQKmlRg7rk8tlorsO87v8RWnBvocHDvgg/WWMA="; | ||
| }) | ||
| ]; | ||
|
|
There was a problem hiding this comment.
Can be dropped, if you bump the version here: mirage/ocaml-github#281
There was a problem hiding this comment.
Can we do that in an other PR?
ocamlPackages.atdgen-codec-runtime: 2.16.0 → 3.0.1
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.