Clean up transducer decoding initialization #14112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Bataev <[email protected]>
Signed-off-by: Vladimir Bataev <[email protected]>
Signed-off-by: Vladimir Bataev <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Refactors transducer decoding initialization to use strongly-typed enums and a single match block for strategy/model logic.
- Introduces
TransducerModelTypeandTransducerDecodingStrategyTypeenums (viaPrettyStrEnum). - Consolidates nested
if-elifdecoding branches into amatch strategy, model_typestructure. - Enhances error reporting for incompatible TDT and multi-blank configurations.
Comments suppressed due to low confidence (3)
nemo/collections/asr/parts/submodules/rnnt_decoding.py:488
- The TSD case instantiates
BeamRNNTInferwithout passingsearch_type='tsd', so it will default to beam search rather than TSD. Please include the correctsearch_typeargument or use a dedicated TSD inferer.
case TransducerDecodingStrategyType.TSD, TransducerModelType.RNNT:
nemo/collections/asr/parts/submodules/rnnt_decoding.py:504
- The ALSD branch uses
BeamRNNTInferbut doesn't setsearch_type='alsd'. This likely runs standard beam search instead of ALSD. Add thesearch_typeparameter or invoke an ALSD-specific infer class.
case TransducerDecodingStrategyType.ALSD, TransducerModelType.RNNT:
nemo/collections/asr/parts/submodules/rnnt_decoding.py:593
- The MAES_BATCH branch does not specify
search_type='maes_batch'when creatingBeamBatchedRNNTInfer, which can lead to incorrect default behavior. Consider adding the explicitsearch_typeargument.
case TransducerDecodingStrategyType.MAES_BATCH, TransducerModelType.RNNT:
Signed-off-by: Vladimir Bataev <[email protected]>
Signed-off-by: Vladimir Bataev <[email protected]>
lilithgrigoryan
approved these changes
Jul 3, 2025
Collaborator
lilithgrigoryan
left a comment
There was a problem hiding this comment.
LGTM. Thank you!
Contributor
|
[🤖]: Hi @artbataev 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Jul 23, 2025
* Clean up strategy selection * Raise error if LM not supported --------- Signed-off-by: Vladimir Bataev <[email protected]> Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Aug 5, 2025
* Clean up strategy selection * Raise error if LM not supported --------- Signed-off-by: Vladimir Bataev <[email protected]> Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Aug 5, 2025
* Clean up strategy selection * Raise error if LM not supported --------- Signed-off-by: Vladimir Bataev <[email protected]> Signed-off-by: Amir Hussein <[email protected]>
nasretdinovr
pushed a commit
to nasretdinovr/NeMo
that referenced
this pull request
Aug 8, 2025
* Clean up strategy selection * Raise error if LM not supported --------- Signed-off-by: Vladimir Bataev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Collection: [ASR]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information