Skip to content

Conversation

@yaoyu-33
Copy link
Collaborator

@yaoyu-33 yaoyu-33 commented Jul 1, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

We are removing all nemo1 multimodal and vision models, the support will not be continued.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

dimapihtar
dimapihtar previously approved these changes Jul 2, 2025
Copy link
Collaborator

@dimapihtar dimapihtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@yaoyu-33 yaoyu-33 added cherry-pick r2.4.0 Pick this label for auto-cherry-picking into r2.4.0 labels Jul 14, 2025
Signed-off-by: yaoyu-33 <[email protected]>
yaoyu-33 added 7 commits July 15, 2025 08:38
Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: yaoyu-33 <[email protected]>
# Conflicts:
#	examples/multimodal/convert_ckpt_to_nemo.py
#	examples/multimodal/text_to_image/convert_hf_ckpt_to_nemo.py
#	examples/multimodal/vision_language_foundation/clip/convert_external_clip_to_nemo.py
#	examples/vision/convert_ckpt_to_nemo.py
#	nemo/collections/vision/modules/common/megatron/vision_transformer.py
#	scripts/checkpoint_converters/convert_clip_hf_to_nemo.py
Signed-off-by: yaoyu-33 <[email protected]>
# Conflicts:
#	nemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py
#	nemo/collections/multimodal/models/text_to_image/dreambooth/dreambooth.py
#	nemo/collections/multimodal/models/text_to_image/stable_diffusion/diffusion_engine.py
#	nemo/collections/multimodal/models/text_to_image/stable_diffusion/ldm/ddpm.py
@github-actions github-actions bot removed the CI label Jul 29, 2025
@github-actions
Copy link
Contributor

[🤖]: Hi @yaoyu-33 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

@yaoyu-33 yaoyu-33 merged commit 6aed959 into main Aug 5, 2025
196 checks passed
@yaoyu-33 yaoyu-33 deleted the yuya/remove_nemo1_multimodal branch August 5, 2025 20:10
nasretdinovr pushed a commit to nasretdinovr/NeMo that referenced this pull request Aug 8, 2025
* remove nemo1 multimodal and vision

Signed-off-by: yaoyu-33 <[email protected]>

* remove some additional mm stuff

Signed-off-by: yaoyu-33 <[email protected]>

* lint

Signed-off-by: yaoyu-33 <[email protected]>

* add back data stuff which still being used in nemo2

Signed-off-by: yaoyu-33 <[email protected]>

* lint

Signed-off-by: yaoyu-33 <[email protected]>

* add init

Signed-off-by: yaoyu-33 <[email protected]>

* update

Signed-off-by: yaoyu-33 <[email protected]>

---------

Signed-off-by: yaoyu-33 <[email protected]>
guyueh1 pushed a commit to guyueh1/NeMo that referenced this pull request Aug 25, 2025
* remove nemo1 multimodal and vision

Signed-off-by: yaoyu-33 <[email protected]>

* remove some additional mm stuff

Signed-off-by: yaoyu-33 <[email protected]>

* lint

Signed-off-by: yaoyu-33 <[email protected]>

* add back data stuff which still being used in nemo2

Signed-off-by: yaoyu-33 <[email protected]>

* lint

Signed-off-by: yaoyu-33 <[email protected]>

* add init

Signed-off-by: yaoyu-33 <[email protected]>

* update

Signed-off-by: yaoyu-33 <[email protected]>

---------

Signed-off-by: yaoyu-33 <[email protected]>
Signed-off-by: Guyue Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick Multi Modal NLP r2.4.0 Pick this label for auto-cherry-picking into r2.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants