feat - GPTSFTChatDataset alignment with OpenAI Messages, compatibility with packed sequences #13367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b2f54f to
e198f58
Compare
5f3f565 to
407cd34
Compare
431c39a to
330b15b
Compare
athitten
reviewed
May 2, 2025
9994375 to
a313478
Compare
athitten
reviewed
May 2, 2025
athitten
reviewed
May 2, 2025
athitten
reviewed
May 2, 2025
|
I reviewed that parts that I could and left comments, but I feel for changes in Also for |
cuichenx
reviewed
May 8, 2025
suiyoubi
previously approved these changes
May 8, 2025
athitten
previously approved these changes
May 9, 2025
741d2f0
33f8a5c to
e7397c5
Compare
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Sam O <[email protected]> Signed-off-by: Sam Oluwalana <[email protected]>
4d4c62a to
65bcaec
Compare
Signed-off-by: Sam Oluwalana <[email protected]>
Signed-off-by: Sam Oluwalana <[email protected]>
Signed-off-by: Sam O <[email protected]>
|
[🤖]: Hi @soluwalana 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
shjwudp
pushed a commit
to shjwudp/NeMo
that referenced
this pull request
May 31, 2025
…y with packed sequences (NVIDIA-NeMo#13367) * feat - GPTSFTChatDataset alignment with OpenAI Messages, compatibility with packed sequences Signed-off-by: Sam O <[email protected]> * feat - GPTSFTChatDataset alignment with OpenAI Messages, compatibility with packed sequences Signed-off-by: Sam Oluwalana <[email protected]> * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> * lint Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> Signed-off-by: Sam Oluwalana <[email protected]> * update test case Signed-off-by: Sam Oluwalana <[email protected]> * F string lint issue Signed-off-by: Sam Oluwalana <[email protected]> * Lint line length Signed-off-by: Sam Oluwalana <[email protected]> * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> * Apply isort and black reformatting Signed-off-by: Sam Oluwalana <[email protected]> * More lint Signed-off-by: Sam Oluwalana <[email protected]> * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> * More lint Signed-off-by: Sam Oluwalana <[email protected]> * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> * Missing parameters Signed-off-by: Sam Oluwalana <[email protected]> * Don't download the model everytime > Signed-off-by: Sam Oluwalana <[email protected]> * Code lint Signed-off-by: Sam Oluwalana <[email protected]> * Rollback change on whitespace in sentencepiece tokenizer Signed-off-by: Sam Oluwalana <[email protected]> * Ensure all loss_masks are labeled as loss_mask Update Tests Signed-off-by: Sam Oluwalana <[email protected]> do not overwrite chat_template by default Signed-off-by: Alexandros Koumparoulis <[email protected]> Can't relative import test function Signed-off-by: Sam Oluwalana <[email protected]> . * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> * Remove duplicate function left in for rebase only" Signed-off-by: Sam Oluwalana <[email protected]> * label loss mask actually loss mask (as there is an attention mask as well) Signed-off-by: Sam Oluwalana <[email protected]> * Lint line length Signed-off-by: Sam Oluwalana <[email protected]> * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> * default use_hf_tokenzier_chat_template = True Signed-off-by: Sam Oluwalana <[email protected]> * Add original build_samples_mapping back in Signed-off-by: Sam Oluwalana <[email protected]> * PR feedback incorporation Signed-off-by: Sam Oluwalana <[email protected]> * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> * PR feedback incorporation Signed-off-by: Sam Oluwalana <[email protected]> * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> * Fix tests Signed-off-by: Sam O <[email protected]> * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> * PR changes Signed-off-by: Sam Oluwalana <[email protected]> * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> * Skip eval unit test (NVIDIA-NeMo#13635) Signed-off-by: Charlie Truong <[email protected]> * Map directly to the NeMo tokenizer path Signed-off-by: Sam Oluwalana <[email protected]> * Rollback change pointing to image cache Signed-off-by: Sam Oluwalana <[email protected]> * Potential fix for code scanning alert no. 14984: Unused import Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Sam O <[email protected]> Signed-off-by: Sam Oluwalana <[email protected]> * correct path in TestData Signed-off-by: Sam Oluwalana <[email protected]> * correct path in TestData Signed-off-by: Sam Oluwalana <[email protected]> --------- Signed-off-by: Sam O <[email protected]> Signed-off-by: Sam Oluwalana <[email protected]> Signed-off-by: soluwalana <[email protected]> Signed-off-by: Charlie Truong <[email protected]> Signed-off-by: Sam O <[email protected]> Co-authored-by: soluwalana <[email protected]> Co-authored-by: Charlie Truong <[email protected]> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: jianbinc <[email protected]>
nasretdinovr
pushed a commit
to nasretdinovr/NeMo
that referenced
this pull request
Aug 8, 2025
…y with packed sequences (NVIDIA-NeMo#13367) * feat - GPTSFTChatDataset alignment with OpenAI Messages, compatibility with packed sequences Signed-off-by: Sam O <[email protected]> * feat - GPTSFTChatDataset alignment with OpenAI Messages, compatibility with packed sequences Signed-off-by: Sam Oluwalana <[email protected]> * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> * lint Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> Signed-off-by: Sam Oluwalana <[email protected]> * update test case Signed-off-by: Sam Oluwalana <[email protected]> * F string lint issue Signed-off-by: Sam Oluwalana <[email protected]> * Lint line length Signed-off-by: Sam Oluwalana <[email protected]> * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> * Apply isort and black reformatting Signed-off-by: Sam Oluwalana <[email protected]> * More lint Signed-off-by: Sam Oluwalana <[email protected]> * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> * More lint Signed-off-by: Sam Oluwalana <[email protected]> * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> * Missing parameters Signed-off-by: Sam Oluwalana <[email protected]> * Don't download the model everytime > Signed-off-by: Sam Oluwalana <[email protected]> * Code lint Signed-off-by: Sam Oluwalana <[email protected]> * Rollback change on whitespace in sentencepiece tokenizer Signed-off-by: Sam Oluwalana <[email protected]> * Ensure all loss_masks are labeled as loss_mask Update Tests Signed-off-by: Sam Oluwalana <[email protected]> do not overwrite chat_template by default Signed-off-by: Alexandros Koumparoulis <[email protected]> Can't relative import test function Signed-off-by: Sam Oluwalana <[email protected]> . * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> * Remove duplicate function left in for rebase only" Signed-off-by: Sam Oluwalana <[email protected]> * label loss mask actually loss mask (as there is an attention mask as well) Signed-off-by: Sam Oluwalana <[email protected]> * Lint line length Signed-off-by: Sam Oluwalana <[email protected]> * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> * default use_hf_tokenzier_chat_template = True Signed-off-by: Sam Oluwalana <[email protected]> * Add original build_samples_mapping back in Signed-off-by: Sam Oluwalana <[email protected]> * PR feedback incorporation Signed-off-by: Sam Oluwalana <[email protected]> * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> * PR feedback incorporation Signed-off-by: Sam Oluwalana <[email protected]> * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> * Fix tests Signed-off-by: Sam O <[email protected]> * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> * PR changes Signed-off-by: Sam Oluwalana <[email protected]> * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> * Skip eval unit test (NVIDIA-NeMo#13635) Signed-off-by: Charlie Truong <[email protected]> * Map directly to the NeMo tokenizer path Signed-off-by: Sam Oluwalana <[email protected]> * Rollback change pointing to image cache Signed-off-by: Sam Oluwalana <[email protected]> * Potential fix for code scanning alert no. 14984: Unused import Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Sam O <[email protected]> Signed-off-by: Sam Oluwalana <[email protected]> * correct path in TestData Signed-off-by: Sam Oluwalana <[email protected]> * correct path in TestData Signed-off-by: Sam Oluwalana <[email protected]> --------- Signed-off-by: Sam O <[email protected]> Signed-off-by: Sam Oluwalana <[email protected]> Signed-off-by: soluwalana <[email protected]> Signed-off-by: Charlie Truong <[email protected]> Signed-off-by: Sam O <[email protected]> Co-authored-by: soluwalana <[email protected]> Co-authored-by: Charlie Truong <[email protected]> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Updates the GPTSFTChatDataset to use the messages format from OpenAI
Updates sequence packing to be compatible with GPTSFTChatDataset
Collection: llm
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information