Fix GHP options #1471
Merged
Fix GHP options #1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asparke2
approved these changes
Aug 15, 2025
There was a problem hiding this comment.
Makes sense to me. Need confirmation from @whiphi92 or @jmaguire1 that this was not intentionally left as "auto" and is indeed a mistake. If all the QAQC and review was done without this set, I don't know what the risk of it changing the results significantly is. Am planning to do a 30k test run on 8/19, so if this can be decided before then GHP can check impacts from that run.
|
Oh, yeah, you're right. So it should definitely be thermally enhanced and I introduced the bug. Oops. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes a bug introduced in #1463
Related Pull Requests
[related PRs from different repositories]
Related Issues
[What issue(s) is the PR addressing]
Checklist
Required:
Optional (not all items may apply):
openstudio tasks.rb update_measureshas been run