Use HPXML class in ResStockArgumentsPostHPXML measure, Take 2 #1389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I may have jumped the gun on merging this ResStockArgumentsPostHPXML refactor PR from post_hpxml_class into latest_os_hpxml without first waiting for @rajeee 's review. The code changes are the same as the original closed/merged PR by @shorowit , and the description (below) is the same as well. I provided my review to Scott's changes (see original closed/merged PR #1388 ) and they look good to me, but it would good to have Rajendra's review as well in case we missed anything, hence "reopening" the PR.
Pull Request Description
Noticed this while working with @Sashadf1 on #1351.
Refactors the ResStockArgumentsPostHPXML measure to use the HPXML class rather than direct XML manipulation. Probably direct XML manipulation was used because it copied the approach used in the OS-HPXML BuildResidentialScheduleFile measure, but there's really no need for it. It's simpler/cleaner to use the HPXML class. (I'm refactoring the BuildResidentialScheduleFile measure here to also use the HPXML class.)
Note that I didn't do any testing beyond checking that the unit tests all pass. I assume that's sufficient?
Checklist
Required:
Optional (not all items may apply):
openstudio tasks.rb update_measures
has been run