Skip to content

Conversation

Sashadf1
Copy link
Collaborator

@Sashadf1 Sashadf1 commented Apr 23, 2025

I may have jumped the gun on merging this ResStockArgumentsPostHPXML refactor PR from post_hpxml_class into latest_os_hpxml without first waiting for @rajeee 's review. The code changes are the same as the original closed/merged PR by @shorowit , and the description (below) is the same as well. I provided my review to Scott's changes (see original closed/merged PR #1388 ) and they look good to me, but it would good to have Rajendra's review as well in case we missed anything, hence "reopening" the PR.

Pull Request Description

Noticed this while working with @Sashadf1 on #1351.

Refactors the ResStockArgumentsPostHPXML measure to use the HPXML class rather than direct XML manipulation. Probably direct XML manipulation was used because it copied the approach used in the OS-HPXML BuildResidentialScheduleFile measure, but there's really no need for it. It's simpler/cleaner to use the HPXML class. (I'm refactoring the BuildResidentialScheduleFile measure here to also use the HPXML class.)

Note that I didn't do any testing beyond checking that the unit tests all pass. I assume that's sufficient?

Checklist

Required:

Optional (not all items may apply):

@Sashadf1 Sashadf1 requested a review from rajeee April 23, 2025 21:20
Copy link
Contributor

@rajeee rajeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good and simpler! Thanks for doing this.

@shorowit shorowit merged commit bbb2b30 into latest-os-hpxml Apr 24, 2025
16 checks passed
@shorowit shorowit deleted the post_hpxml_class branch April 24, 2025 19:28
@joseph-robertson joseph-robertson added this to the ResStock v2025_R1 milestone Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants